No need to create an intermediary array

Author: garydgregory

src/main/java/org/apache/commons/cli/DefaultParser.java

@@ -516,7 +516,7 @@ private void handleProperties(final Properties properties) throws ParseException
                 final String value = properties.getProperty(option);
 
                 if (opt.hasArg()) {
-                    if (Util.isEmpty(opt.getValues())) {
+                    if (opt.isValuesEmpty()) {
                         opt.processValue(stripLeadingAndTrailingQuotesDefaultOff(value));
                     }
                 } else if (!("yes".equalsIgnoreCase(value) || "true".equalsIgnoreCase(value) || "1".equalsIgnoreCase(value))) {

src/main/java/org/apache/commons/cli/Option.java

@@ -694,7 +694,7 @@ public Object getType() {
      * @return the value/first value of this Option or {@code null} if there is no value.
      */
     public String getValue() {
-        return hasNoValues() ? null : values.get(0);
+        return isValuesEmpty() ? null : values.get(0);
     }
 
     /**
@@ -705,7 +705,7 @@ public String getValue() {
      * @throws IndexOutOfBoundsException if index is less than 1 or greater than the number of the values for this Option.
      */
     public String getValue(final int index) throws IndexOutOfBoundsException {
-        return hasNoValues() ? null : values.get(index);
+        return isValuesEmpty() ? null : values.get(index);
     }
 
     /**
@@ -725,7 +725,7 @@ public String getValue(final String defaultValue) {
      * @return the values of this Option as a String array or an empty array if there are no values.
      */
     public String[] getValues() {
-        return hasNoValues() ? null : values.toArray(EMPTY_STRING_ARRAY);
+        return isValuesEmpty() ? null : values.toArray(EMPTY_STRING_ARRAY);
     }
 
     /**
@@ -787,15 +787,6 @@ public boolean hasLongOpt() {
         return longOption != null;
     }
 
-    /**
-     * Tests whether this Option has any values.
-     *
-     * @return whether this Option has any values.
-     */
-    private boolean hasNoValues() {
-        return values.isEmpty();
-    }
-
     /**
      * Tests whether this Option can have an optional argument.
      *
@@ -834,6 +825,15 @@ public boolean isRequired() {
         return required;
     }
 
+    /**
+     * Tests whether this Option has any values.
+     *
+     * @return whether this Option has any values.
+     */
+    boolean isValuesEmpty() {
+        return values.isEmpty();
+    }
+
     /**
      * Processes the value. If this Option has a value separator the value will have to be parsed into individual tokens. When n-1 tokens have been processed
      * and there are more value separators in the value, parsing is ceased and the remaining characters are added as a single token.

src/main/java/org/apache/commons/cli/Parser.java

@@ -231,7 +231,7 @@ public void processArgs(final Option opt, final ListIterator<String> iter) throw
                 break;
             }
         }
-        if (opt.getValues() == null && !opt.hasOptionalArg()) {
+        if (opt.isValuesEmpty() && !opt.hasOptionalArg()) {
             throw new MissingArgumentException(opt);
         }
     }
@@ -285,7 +285,7 @@ protected void processProperties(final Properties properties) throws ParseExcept
                 // get the value from the properties instance
                 final String value = properties.getProperty(option);
                 if (opt.hasArg()) {
-                    if (Util.isEmpty(opt.getValues())) {
+                    if (opt.isValuesEmpty()) {
                         try {
                             opt.processValue(value);
                         } catch (final RuntimeException exp) { // NOPMD