Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include hash of result set metadata in prepared statement id #1222

Closed
beltran opened this issue Oct 19, 2018 · 8 comments
Closed

Include hash of result set metadata in prepared statement id #1222

beltran opened this issue Oct 19, 2018 · 8 comments

Comments

@beltran
Copy link
Contributor

beltran commented Oct 19, 2018

Implement the driver part of https://issues.apache.org/jira/browse/CASSANDRA-10786. This is a protocol 5 change. The problem with doing it is that it breaks protocol v5 against 3.11 so we wouldn't have a way of testing it in travis until Cassandra 4 is released.

@alourie
Copy link
Contributor

alourie commented Oct 20, 2018

@beltran we possibly could run them as a separate test with ccm running on trunk.

@Zariel
Copy link
Contributor

Zariel commented Oct 20, 2018

I think fundamentally if C* are not going to port this to all V5 versions then they should reconsider how they've implemented it, I really don't want to have checks in the protocol layer like if proto == 5 && version >= 4.0.0 this just seems silly

@Zariel
Copy link
Contributor

Zariel commented Oct 21, 2018

Or we just dont support v5beta anymore?

@beltran
Copy link
Contributor Author

beltran commented Oct 21, 2018

I believe the approach other drivers have taken is to let v5 break for 3.11 and implement it as it only had to work for 4.0. I've verified this with the python driver but I'll check the java one later.

@beltran
Copy link
Contributor Author

beltran commented Oct 22, 2018

It's the same for the java driver. I haven't seen it officially stated anywhere but it seems like V5 just doesn't work for 3.11. It breaks with prepared statements.

@alourie
Copy link
Contributor

alourie commented Oct 26, 2018

Maybe I could work on a patch for C* that wouldn't allow using V5 with 3.x :-)

@martin-sucha martin-sucha added this to the Binary protocol v5 milestone Dec 31, 2020
@OleksiienkoMykyta
Copy link
Contributor

OleksiienkoMykyta commented Feb 20, 2025

Now it's not relevant, Cassandra v3 uses native protocol v4 as it's highest-supported version. The native protocol v5 was introduced in Cassandra v4.0.
About the (Include hash of result set metadata in prepared statement id), will be fixed by #1822
Should be closed.

@joao-r-reis
Copy link
Contributor

This is being tracked in CASSGO-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants