Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aws-secrets-manager: minor improves to test coverage #6673

Open
JiriOndrusek opened this issue Oct 22, 2024 · 0 comments
Open

Aws-secrets-manager: minor improves to test coverage #6673

JiriOndrusek opened this issue Oct 22, 2024 · 0 comments
Assignees
@JiriOndrusek
Labels
area/aws-secrets-manager area/testing enhancement New feature or request test

Comments

@JiriOndrusek
Copy link
Contributor

JiriOndrusek commented Oct 22, 2024 •
edited
Loading

Describe the feature here

  • It might be possible to use BaseAWs2TestSupport as a parent for a test in aws-secret-manager to cover default credential provider. (See i.e. aws2-ses or others)
  • It would be nice to verify existence of other headers (SECRET_ID is already covered) see the doc
@JiriOndrusek JiriOndrusek added the enhancement New feature or request label Oct 22, 2024
@JiriOndrusek JiriOndrusek self-assigned this Oct 22, 2024
@jamesnetherton jamesnetherton changed the title Aws-sercret-manager: minor improves to test coverage Aws-sercrets-manager: minor improves to test coverage Oct 24, 2024
@jamesnetherton jamesnetherton changed the title Aws-sercrets-manager: minor improves to test coverage Aws-secrets-manager: minor improves to test coverage Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiriOndrusek JiriOndrusek

Labels
area/aws-secrets-manager area/testing enhancement New feature or request test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JiriOndrusek