Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Metrics from runner expanded composites aren't mapped back to user terms. #31971

Open
Tracked by #29650
lostluck opened this issue Jul 24, 2024 · 0 comments
Open
Tracked by #29650

Comments

@lostluck
Copy link
Contributor

lostluck commented Jul 24, 2024

For example: SDFs and Combines expand out to a few sub transforms, but their metrics aren't visible in the prism UI.

image

Note how the GenerateRays SDF has an output pcollection, but reports 0 elements, and similarly, TraceFn which consumes it, reports 0 elements input, but emitted several itself.

This appears to primarily affect output PCollection metrics, and the transform's Profiling metrics .

Largely this means summing in the profile metrics from the exploded stages, but in some ways ignoring/discarding metrics from the PCollections of those stages.

This only affects a merged view however. In a view of the fused + generated transforms, they can be properly ascribed to their source components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant