Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Manage GCS soft delete policy in temp location #31330

Closed
2 of 18 tasks
shunping opened this issue May 17, 2024 · 7 comments
Closed
2 of 18 tasks

[Feature Request]: Manage GCS soft delete policy in temp location #31330

shunping opened this issue May 17, 2024 · 7 comments

Comments

@shunping
Copy link
Contributor

shunping commented May 17, 2024

What would you like to happen?

Background

GCS has introduced soft delete policy feature in new and existing buckets since March 2024. By default, the soft delete retention period is 7 days. (https://cloud.google.com/resources/storage/soft-delete-announce?hl=en)

This feature may impact Beam users who use temp and staging locations in GCS for temporary files and pipeline execution, because storage during the soft delete window will still be billed.

Tasks

  • Disable soft delete policy when creating a new default bucket for a project
  • Warn users about potential costs if the temporary location is in a bucket with the soft delete policy enabled

Issue Priority

Priority: 2

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@shunping
Copy link
Contributor Author

.take-issue

@kennknowles
Copy link
Member

What is the status here?

@shunping
Copy link
Contributor Author

shunping commented Jun 7, 2024

Everything is done, except for adding a warning to Python SDK if the bucket has soft delete enabled.

@kennknowles
Copy link
Member

I am asking because it is targeting 2.57.0 release. Are we able to cherry-pick? Or is it good enough having some functionality on 2.57.0 branch?

@shunping
Copy link
Contributor Author

The three merged commits should be good for cherry-picking. I am waiting for the fourth(last) one to be reviewed. If it can get through today or tomorrow, can we cherry pick it as well?

@shunping
Copy link
Contributor Author

Ok. the remaining task is done and merged. I think we are good to close this issue @kennknowles.

@kennknowles
Copy link
Member

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants