Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Compile Java Examples Main on Java 11/17/21 when run Java Example Tests #28967

Open
16 tasks
Abacn opened this issue Oct 12, 2023 · 0 comments
Open
16 tasks
Assignees

Comments

@Abacn
Copy link
Contributor

Abacn commented Oct 12, 2023

What would you like to happen?

Currently we run Java Examples in different Java versions (11, 17), e.g.

In current tests (Jenkins, GHA Examples Dataflow v1), java home is always Java8, and it compile and run tests on Java 11/17, see

switches "-Pjava11Home=${commonJobProperties.JAVA_11_HOME}"

(note that GHA Examples Dataflow v2 currently just setup a single Java version, which is not quite aligned with this pattern)

However, the test scope source of :example:java project is really a thin wrapper for the examples, which live in main scope. This actually means the pipeline is compiled with Java8, then run with Java11/17 runtime, which is not quite we want (GHA Dataflow v2 accidentally compile all sources with Java11/17 though)

We should clean up current setting to make the Example test to

  • all beam dependencies (e.g. Java core, runners) compile on Java 8 -- in alignment with released version
  • examples main and test src compile with given Java version
  • run test with given Java version

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@github-actions github-actions bot added the P2 label Oct 12, 2023
@Abacn Abacn self-assigned this Oct 12, 2023
@Abacn Abacn mentioned this issue Oct 12, 2023
3 tasks
@Abacn Abacn changed the title [Feature Request]: Support Compile Java Examples on Java 21 [Feature Request]: Compile Java Examples Main on Java 11/17/21 when run Java Example Tests Oct 23, 2023
@Abacn Abacn changed the title [Feature Request]: Compile Java Examples Main on Java 11/17/21 when run Java Example Tests [Task]: Compile Java Examples Main on Java 11/17/21 when run Java Example Tests Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant