Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Allow users to pass their own service name for google cloud profiler #26280

Closed
1 of 15 tasks
riteshghorse opened this issue Apr 14, 2023 · 0 comments · Fixed by #26220
Closed
1 of 15 tasks

[Task]: Allow users to pass their own service name for google cloud profiler #26280

riteshghorse opened this issue Apr 14, 2023 · 0 comments · Fixed by #26220
Assignees
@riteshghorse
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. P3 python task
Milestone
2.48.0 Release

Comments

@riteshghorse
Copy link
Contributor

riteshghorse commented Apr 14, 2023 •
edited
Loading

What needs to happen?

Currently, on enabling google cloud profiler, the service name for profiler is set from the job name. There should be an option for users to set a custom service name by passing something like:
--dataflow_service_options=enable_google_cloud_profiler=sample

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@riteshghorse riteshghorse self-assigned this Apr 14, 2023
@github-actions github-actions bot added the P3 label Apr 14, 2023
@riteshghorse riteshghorse mentioned this issue Apr 14, 2023
Merged
3 tasks
@kennknowles kennknowles removed the P1 label Apr 27, 2023
@github-actions github-actions bot added this to the 2.48.0 Release milestone May 3, 2023
@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riteshghorse riteshghorse

Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. P3 python task
Projects
None yet
Milestone
2.48.0 Release
Development

Successfully merging a pull request may close this issue.

[Python] Allow users to pass service name for profiler riteshghorse/beam
3 participants
@kennknowles @tvalentyn @riteshghorse