Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Top.Smallest / Largest and the ...PerKey helper combiners should support a comparison key param #25888

Open
1 of 15 tasks
tvalentyn opened this issue Mar 17, 2023 · 2 comments

Comments

@tvalentyn
Copy link
Contributor

What would you like to happen?

See Top.Of implementation that supports the key :

key: (optional) a mapping of elements to a comparable key, similar to
the key argument of Python's sorting methods.

Let's allow the same for

Top.Smallest / Largest and the ...PerKey combiners, see:

def Largest(pcoll, n, has_defaults=True):

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tvalentyn
Copy link
Contributor Author

cc: @harrisonlimh

@harrisonlimh
Copy link
Contributor

.take-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants