Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Support Protobuf v4 in Python SDK. #24569

Closed
tvalentyn opened this issue Dec 7, 2022 · 5 comments · Fixed by #24599
Closed

[Task]: Support Protobuf v4 in Python SDK. #24569

tvalentyn opened this issue Dec 7, 2022 · 5 comments · Fixed by #24599
Assignees
Labels
dependencies Pull requests that update a dependency file P2 task

Comments

@tvalentyn
Copy link
Contributor

What needs to happen?

Upgrade upper & lower bounds to use Protobuf v4.

Issue Priority

Priority: 2

Issue Component

Component: dependencies

@github-actions github-actions bot added dependencies Pull requests that update a dependency file P2 labels Dec 7, 2022
@tvalentyn
Copy link
Contributor Author

Requirements are specified in: https://github.com/apache/beam/blob/1ba7821a09cb1b9a1793f7044ed64aabf55f7713/sdks/python/setup.py

Protobuf releases switched to v4 in: https://pypi.org/project/protobuf/#history

Let's try to switch to Protobuf v4, or identify (what if anything) doesn't work.

To avoid having a mismatch at startup and at runtime for this dependency, let's tighten the upper bound (e.g. protobuf<=4.21.11 and rely on dependabot for perodic upgrades, or otherwise make periodic upgrades for every release milestone if we still need special casing (which is the case for MacOS now), how we do with cloudpickle, see: #23119

@tvalentyn
Copy link
Contributor Author

@AnandInguva would you have time sometime this/next week to take a look if Protobuf v4 just works? Thanks.

@AnandInguva
Copy link
Contributor

.take-issue

@AnandInguva
Copy link
Contributor

We are still blocked on Tensorflow for the protobuf update. Tensorflow is still on protobuf >= 3.9.2, < 3.20
https://github.com/tensorflow/tensorflow/blob/d5b57ca93e506df258271ea00fc29cf98383a374/tensorflow/tools/pip_package/setup.py#L102

@aucampia
Copy link

We are still blocked on Tensorflow for the protobuf update. Tensorflow is still on protobuf >= 3.9.2, < 3.20 https://github.com/tensorflow/tensorflow/blob/d5b57ca93e506df258271ea00fc29cf98383a374/tensorflow/tools/pip_package/setup.py#L102

I made an upstream issue to track this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file P2 task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants