-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Update RunInference Notebooks to use Custom Inference Functions #24334
Comments
Would it be better to just add one more notebook using Huggingface generate rather than modifying the existing examples (since the existing ones don't really require calling a non-default inference function)? |
@jrmccluskey @damccorm I would like to contribute to this issue , I have one question though. What is the name of the convenience function that was agreed upon in #24062 |
It depends on the model handler, but for PyTorchTensor its
Roughly they should all follow the |
#27305 should address most of this, we still need to update https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/run_inference_pytorch_tensorflow_sklearn.ipynb |
@damccorm what model should I use for the example? |
Hey @smeet07 we shouldn't need to use a new model, we just need to get rid of |
Alright |
What needs to happen?
Once Beam 2.44 is released, the RunInference example notebooks should be updated to take advantage of the custom inference function capabilities added in #22572
Issue Priority
Priority: 2
Issue Component
Component: run-inference
The text was updated successfully, but these errors were encountered: