Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Iterable todo In CoGroupByKey #21556

Closed
damccorm opened this issue Jun 5, 2022 · 3 comments · Fixed by #22984
Closed

Fix Iterable todo In CoGroupByKey #21556

damccorm opened this issue Jun 5, 2022 · 3 comments · Fixed by #22984
Assignees
Labels
bug core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 5, 2022

 

Change iterable_input_value_types to be either type.Iterable or rename the variable to specify it is supposed to be a list.

# TODO: Change List[t] to Iterable[t]

Imported from Jira BEAM-14084. Original Jira may contain additional context.
Reported by: Ryan.Thompson.

@ryanthompson591
Copy link
Contributor

.take-issue

@ryanthompson591
Copy link
Contributor

ryanthompson591 commented Sep 13, 2022

Fixed in #22984

This will be a breaking change to any pipelines that expect the output of CoGroupByKey to be a list instead of an iterable.

I've documentation on how to fix pipelines for this breaking change.

@ryanthompson591
Copy link
Contributor

.add-label done-and-done

@damccorm damccorm added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Oct 19, 2022
@tvalentyn tvalentyn mentioned this issue Nov 4, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants