Skip to content

GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input #47667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-47666: [C++][Parquet] Fix DeltaByteArrayDecoder with corrupted input #47667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpp/src/parquet/decoder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ struct ArrowBinaryHelper<ByteArrayType, ArrowBinaryType> {

Status AppendValue(const uint8_t* data, int32_t length,
std::optional<int64_t> estimated_remaining_data_length = {}) {
if (ARROW_PREDICT_FALSE(data == nullptr)) {
Copy link
Member

@mapleFU mapleFU Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we need find out in which case this is nullptr

Copy link
Member

@pitrou pitrou Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you investigated this @mapleFU ?

return Status::Invalid("data is nullptr");
}
if (!kIsBinaryView && estimated_remaining_data_length.has_value()) {
// Assume Prepare() was already called with an estimated_data_length
builder_->UnsafeAppend(data, length);
Expand Down Expand Up @@ -207,6 +210,9 @@ struct ArrowBinaryHelper<FLBAType, ::arrow::FixedSizeBinaryType> {

Status AppendValue(const uint8_t* data, int32_t length,
std::optional<int64_t> estimated_remaining_data_length = {}) {
if (ARROW_PREDICT_FALSE(data == nullptr)) {
return Status::Invalid("data is nullptr");
}
acc_->UnsafeAppend(data);
return Status::OK();
}
Expand Down
Loading