Skip to content

MINOR: [C++] Fix OTel 1.19 compat after silent breaking change #45859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

MINOR: [C++] Fix OTel 1.19 compat after silent breaking change #45859

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a4476e
MINOR: [C++] Fix OTel 1.19 compat after silent breaking change
lidavidm Mar 19, 2025
e653385
Update cpp/src/arrow/util/tracing_internal.cc
lidavidm May 30, 2025
4e9a98b
Merge remote-tracking branch 'upstream/main' into minor-otel-119
lidavidm May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/src/arrow/util/tracing_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ class OtlpOStreamExporter final : public sdktrace::SpanExporter {
std::chrono::microseconds(0)) noexcept override {
return exporter_.Shutdown(timeout);
}
// XXX: OTel 1.19 silent breaking change: this must be overridden
bool ForceFlush(std::chrono::microseconds /*timeout*/) noexcept override {
return true;
}

private:
std::basic_ostream<char>* out_;
Expand Down
Loading