From 0bddf84fb805a65feca34a1daf664be0d571c144 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Sun, 8 Jan 2023 00:03:03 +0100 Subject: [PATCH 1/3] add PR template --- .github/pull_request_template.md | 62 +++++++++++++++++++++++++++++++ dev/release/rat_exclude_files.txt | 1 + 2 files changed, 63 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000000..b7867e90674 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,62 @@ +# Which issue does this PR close? + + +Closes # + +# Rationale for this change + + + +# What changes are included in this PR? + + + +# Are these changes tested? + + + +# Are there any user-facing changes? + + + + \ No newline at end of file diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt index 151a5148b3e..5b7428ef8b8 100644 --- a/dev/release/rat_exclude_files.txt +++ b/dev/release/rat_exclude_files.txt @@ -214,3 +214,4 @@ r/inst/include/cpp11/*.hpp r/tools/nixlibs-allowlist.txt .gitattributes ruby/red-arrow/.yardopts +.github/pull_request_template.md \ No newline at end of file From e4dd2bb8d4874960d39ef403534535790368a667 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Mon, 9 Jan 2023 16:32:26 +0100 Subject: [PATCH 2/3] Update .github/pull_request_template.md Co-authored-by: David Li --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b7867e90674..1e01a323d28 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -5,7 +5,7 @@ Thanks for opening a pull request! If this is your first pull request you can find detailed information on how to contribute here: * [New Contributor's Guide](https://arrow.apache.org/docs/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request) - * [ContributingOverview](https://arrow.apache.org/docs/developers/overview.html) + * [Contributing Overview](https://arrow.apache.org/docs/developers/overview.html) If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose From 9b2df77cf547b383eb3862aa7521391439c82f58 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Mon, 9 Jan 2023 16:34:23 +0100 Subject: [PATCH 3/3] Update .github/pull_request_template.md --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1e01a323d28..3ed153d0a22 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,8 +4,8 @@ Thanks for opening a pull request! If this is your first pull request you can find detailed information on how to contribute here: - * [New Contributor's Guide](https://arrow.apache.org/docs/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request) - * [Contributing Overview](https://arrow.apache.org/docs/developers/overview.html) + * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request) + * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html) If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose