From acc8dc015735fd3ecdb522a12847ab6baea0a809 Mon Sep 17 00:00:00 2001 From: Dhruv Vats Date: Wed, 7 Sep 2022 12:31:24 +0530 Subject: [PATCH 1/5] ARROW-17632: Add Arrow location info --- cpp/src/arrow/ArrowConfig.cmake.in | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in index f0aa1bc959b..89f3ea47e76 100644 --- a/cpp/src/arrow/ArrowConfig.cmake.in +++ b/cpp/src/arrow/ArrowConfig.cmake.in @@ -172,3 +172,12 @@ endmacro() arrow_keep_backward_compatibility(Arrow arrow) check_required_components(Arrow) + +if(NOT Arrow_FIND_QUIETLY) + message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})") + message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}") + message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}") + message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}") + message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}") + message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") +endif() \ No newline at end of file From 694bc8bf88287d741211bb6019adf95ee873e82a Mon Sep 17 00:00:00 2001 From: Dhruv Vats Date: Wed, 7 Sep 2022 12:43:45 +0530 Subject: [PATCH 2/5] ARROW-17632: Add newline at the end of file --- cpp/src/arrow/ArrowConfig.cmake.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in index 89f3ea47e76..7585869baee 100644 --- a/cpp/src/arrow/ArrowConfig.cmake.in +++ b/cpp/src/arrow/ArrowConfig.cmake.in @@ -180,4 +180,4 @@ if(NOT Arrow_FIND_QUIETLY) message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}") message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}") message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") -endif() \ No newline at end of file +endif() From 06b914b309860fceed051fa6810c15d62d221004 Mon Sep 17 00:00:00 2001 From: Dhruv Vats Date: Wed, 7 Sep 2022 17:37:25 +0530 Subject: [PATCH 3/5] ARROW-17632: Add function arrow_show_details --- cpp/src/arrow/ArrowConfig.cmake.in | 20 +++++++++++-------- cpp/src/arrow/ArrowTestingConfig.cmake.in | 2 ++ .../arrow/dataset/ArrowDatasetConfig.cmake.in | 2 ++ .../engine/ArrowSubstraitConfig.cmake.in | 2 ++ .../arrow/flight/ArrowFlightConfig.cmake.in | 2 ++ .../flight/ArrowFlightTestingConfig.cmake.in | 2 ++ .../flight/sql/ArrowFlightSqlConfig.cmake.in | 2 ++ cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in | 2 ++ cpp/src/gandiva/GandivaConfig.cmake.in | 2 ++ cpp/src/parquet/ParquetConfig.cmake.in | 2 ++ cpp/src/plasma/PlasmaConfig.cmake.in | 2 ++ python/pyarrow/src/ArrowPythonConfig.cmake.in | 2 ++ .../src/ArrowPythonFlightConfig.cmake.in | 2 ++ 13 files changed, 36 insertions(+), 8 deletions(-) diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in index 7585869baee..c14e6a18d28 100644 --- a/cpp/src/arrow/ArrowConfig.cmake.in +++ b/cpp/src/arrow/ArrowConfig.cmake.in @@ -173,11 +173,15 @@ arrow_keep_backward_compatibility(Arrow arrow) check_required_components(Arrow) -if(NOT Arrow_FIND_QUIETLY) - message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})") - message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}") - message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}") - message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}") - message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}") - message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") -endif() +function(arrow_show_details PACKAGE_NAME) + if(NOT ${PACKAGE_NAME}_FIND_QUIETLY) + string(TOUPPER ${PACKAGE_NAME} package_name_upper) + message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}") + message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}") + message(STATUS "Found the ${PACKAGE_NAME} import library: ${${package_name_upper}_IMPORT_LIB}") + message(STATUS "Found the ${PACKAGE_NAME} static library: ${${package_name_upper}_STATIC_LIB}") + endif() +endfunction() + +arrow_show_details(arrow) + diff --git a/cpp/src/arrow/ArrowTestingConfig.cmake.in b/cpp/src/arrow/ArrowTestingConfig.cmake.in index 03775b043ed..373f0fe29aa 100644 --- a/cpp/src/arrow/ArrowTestingConfig.cmake.in +++ b/cpp/src/arrow/ArrowTestingConfig.cmake.in @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowTestingTargets.cmake") arrow_keep_backward_compatibility(ArrowTesting arrow_testing) check_required_components(ArrowTesting) + +arrow_show_details(arrow_testing) diff --git a/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in b/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in index 38b9baf4089..ed765ed6a9d 100644 --- a/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in +++ b/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowDatasetTargets.cmake") arrow_keep_backward_compatibility(ArrowDataset arrow_dataset) check_required_components(ArrowDataset) + +arrow_show_details(arrow_dataset) diff --git a/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in b/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in index 2263c735d26..dd80a2c602f 100644 --- a/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in +++ b/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in @@ -36,3 +36,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowSubstraitTargets.cmake") arrow_keep_backward_compatibility(ArrowSubstrait arrow_substrait) check_required_components(ArrowSubstrait) + +arrow_show_details(arrow_substrait) diff --git a/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in b/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in index 04560f91e08..17d6bcddd40 100644 --- a/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in +++ b/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightTargets.cmake") arrow_keep_backward_compatibility(ArrowFlight arrow_flight) check_required_components(ArrowFlight) + +arrow_show_details(arrow_flight) diff --git a/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in b/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in index 0c42c5c1ff8..c710e2a80d2 100644 --- a/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in +++ b/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightTestingTargets.cmake") arrow_keep_backward_compatibility(ArrowFlightTetsing arrow_flight_testing) check_required_components(ArrowFlightTesting) + +arrow_show_details(arrow_flight_testing) diff --git a/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in b/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in index 9d0e9ea2dac..e5ee7f33966 100644 --- a/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in +++ b/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightSqlTargets.cmake") arrow_keep_backward_compatibility(ArrowFlightSql arrow_flight_sql) check_required_components(ArrowFlightSql) + +arrow_show_details(arrow_flight_sql) diff --git a/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in b/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in index e987d82a3a1..4a5f6f781a5 100644 --- a/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in +++ b/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowCUDATargets.cmake") arrow_keep_backward_compatibility(ArrowCUDA arrow_cuda) check_required_components(ArrowCUDA) + +arrow_show_details(arrow_cuda) diff --git a/cpp/src/gandiva/GandivaConfig.cmake.in b/cpp/src/gandiva/GandivaConfig.cmake.in index 861166dc3d9..b7fe16fbc8c 100644 --- a/cpp/src/gandiva/GandivaConfig.cmake.in +++ b/cpp/src/gandiva/GandivaConfig.cmake.in @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/GandivaTargets.cmake") arrow_keep_backward_compatibility(Gandiva gandiva) check_required_components(Gandiva) + +arrow_show_details(gandiva) diff --git a/cpp/src/parquet/ParquetConfig.cmake.in b/cpp/src/parquet/ParquetConfig.cmake.in index 19f1b4b6395..f15a4970a9b 100644 --- a/cpp/src/parquet/ParquetConfig.cmake.in +++ b/cpp/src/parquet/ParquetConfig.cmake.in @@ -41,3 +41,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ParquetTargets.cmake") arrow_keep_backward_compatibility(Parquet parquet) check_required_components(Parquet) + +arrow_show_details(parquet) diff --git a/cpp/src/plasma/PlasmaConfig.cmake.in b/cpp/src/plasma/PlasmaConfig.cmake.in index cdd312d04cb..975f46ba1de 100644 --- a/cpp/src/plasma/PlasmaConfig.cmake.in +++ b/cpp/src/plasma/PlasmaConfig.cmake.in @@ -46,3 +46,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/PlasmaTargets.cmake") arrow_keep_backward_compatibility(Plasma plasma) check_required_components(Plasma) + +arrow_show_details(plasma) diff --git a/python/pyarrow/src/ArrowPythonConfig.cmake.in b/python/pyarrow/src/ArrowPythonConfig.cmake.in index cab92cddfd3..a51a66c296a 100644 --- a/python/pyarrow/src/ArrowPythonConfig.cmake.in +++ b/python/pyarrow/src/ArrowPythonConfig.cmake.in @@ -37,3 +37,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowPythonTargets.cmake") arrow_keep_backward_compatibility(ArrowPython arrow_python) check_required_components(ArrowPython) + +arrow_show_details(arrow_python) diff --git a/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in b/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in index fb2ad918fc8..3fd57e31211 100644 --- a/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in +++ b/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowPythonFlightTargets.cmake") arrow_keep_backward_compatibility(ArrowPythonFlight arrow_python_flight) check_required_components(ArrowPythonFlight) + +arrow_show_details(arrow_python_flight) From adf8d284a3dfbfafd32eff03be08a232275b5553 Mon Sep 17 00:00:00 2001 From: Dhruv Vats Date: Sun, 11 Sep 2022 19:14:19 +0530 Subject: [PATCH 4/5] ARROW-17632: Convert arrow_show_details to macro --- cpp/examples/minimal_build/CMakeLists.txt | 8 ++++++- cpp/src/arrow/ArrowConfig.cmake.in | 22 ++++++++++--------- cpp/src/arrow/ArrowTestingConfig.cmake.in | 2 +- .../arrow/dataset/ArrowDatasetConfig.cmake.in | 2 +- .../engine/ArrowSubstraitConfig.cmake.in | 2 +- .../arrow/flight/ArrowFlightConfig.cmake.in | 2 +- .../flight/ArrowFlightTestingConfig.cmake.in | 2 +- .../flight/sql/ArrowFlightSqlConfig.cmake.in | 2 +- cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in | 2 +- cpp/src/gandiva/GandivaConfig.cmake.in | 2 +- cpp/src/parquet/ParquetConfig.cmake.in | 2 +- cpp/src/plasma/PlasmaConfig.cmake.in | 2 +- python/pyarrow/src/ArrowPythonConfig.cmake.in | 2 +- .../src/ArrowPythonFlightConfig.cmake.in | 2 +- 14 files changed, 31 insertions(+), 23 deletions(-) diff --git a/cpp/examples/minimal_build/CMakeLists.txt b/cpp/examples/minimal_build/CMakeLists.txt index 6f4d9cefab4..2e492f11053 100644 --- a/cpp/examples/minimal_build/CMakeLists.txt +++ b/cpp/examples/minimal_build/CMakeLists.txt @@ -21,7 +21,13 @@ project(ArrowMinimalExample) option(ARROW_LINK_SHARED "Link to the Arrow shared library" ON) -find_package(Arrow REQUIRED) +#find_package(Arrow REQUIRED) +find_package(ArrowCUDA REQUIRED) +find_package(ArrowDataset REQUIRED) +#find_package(ArrowTesting REQUIRED) +find_package(ArrowFlight REQUIRED) +#find_package(ArrowFlightSql REQUIRED) +#find_package(Gandiva REQUIRED) if(NOT DEFINED CMAKE_CXX_STANDARD) set(CMAKE_CXX_STANDARD 11) diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in index c14e6a18d28..8386bcd7280 100644 --- a/cpp/src/arrow/ArrowConfig.cmake.in +++ b/cpp/src/arrow/ArrowConfig.cmake.in @@ -173,15 +173,17 @@ arrow_keep_backward_compatibility(Arrow arrow) check_required_components(Arrow) -function(arrow_show_details PACKAGE_NAME) - if(NOT ${PACKAGE_NAME}_FIND_QUIETLY) - string(TOUPPER ${PACKAGE_NAME} package_name_upper) - message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}") - message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}") - message(STATUS "Found the ${PACKAGE_NAME} import library: ${${package_name_upper}_IMPORT_LIB}") - message(STATUS "Found the ${PACKAGE_NAME} static library: ${${package_name_upper}_STATIC_LIB}") +macro(arrow_show_details package_name variable_prefix) + if(NOT ${package_name}_FIND_QUIETLY AND NOT ${package_name}_SHOWED_DETAILS) + message(STATUS "${package_name} version: ${${package_name}_VERSION}") + message(STATUS "Found the ${package_name} shared library: ${${variable_prefix}_SHARED_LIB}" + ) + message(STATUS "Found the ${package_name} import library: ${${variable_prefix}_IMPORT_LIB}" + ) + message(STATUS "Found the ${package_name} static library: ${${variable_prefix}_STATIC_LIB}" + ) + set(${package_name}_SHOWED_DETAILS TRUE) endif() -endfunction() - -arrow_show_details(arrow) +endmacro() +arrow_show_details(Arrow ARROW) diff --git a/cpp/src/arrow/ArrowTestingConfig.cmake.in b/cpp/src/arrow/ArrowTestingConfig.cmake.in index 373f0fe29aa..87ee9e755e1 100644 --- a/cpp/src/arrow/ArrowTestingConfig.cmake.in +++ b/cpp/src/arrow/ArrowTestingConfig.cmake.in @@ -35,4 +35,4 @@ arrow_keep_backward_compatibility(ArrowTesting arrow_testing) check_required_components(ArrowTesting) -arrow_show_details(arrow_testing) +arrow_show_details(ArrowTesting ARROW_TESTING) diff --git a/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in b/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in index ed765ed6a9d..6816f2c837d 100644 --- a/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in +++ b/cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in @@ -36,4 +36,4 @@ arrow_keep_backward_compatibility(ArrowDataset arrow_dataset) check_required_components(ArrowDataset) -arrow_show_details(arrow_dataset) +arrow_show_details(ArrowDataset ARROW_DATASET) diff --git a/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in b/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in index dd80a2c602f..2e96d372ad7 100644 --- a/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in +++ b/cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in @@ -37,4 +37,4 @@ arrow_keep_backward_compatibility(ArrowSubstrait arrow_substrait) check_required_components(ArrowSubstrait) -arrow_show_details(arrow_substrait) +arrow_show_details(ArrowSubstrait ARROW_SUBSTRAIT) diff --git a/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in b/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in index 17d6bcddd40..70beb901c85 100644 --- a/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in +++ b/cpp/src/arrow/flight/ArrowFlightConfig.cmake.in @@ -35,4 +35,4 @@ arrow_keep_backward_compatibility(ArrowFlight arrow_flight) check_required_components(ArrowFlight) -arrow_show_details(arrow_flight) +arrow_show_details(ArrowFlight ARROW_FLIGHT) diff --git a/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in b/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in index c710e2a80d2..f072b2603e3 100644 --- a/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in +++ b/cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in @@ -36,4 +36,4 @@ arrow_keep_backward_compatibility(ArrowFlightTetsing arrow_flight_testing) check_required_components(ArrowFlightTesting) -arrow_show_details(arrow_flight_testing) +arrow_show_details(ArrowFlightTesting ARROW_FLIGHT_TESTING) diff --git a/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in b/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in index e5ee7f33966..3a70dbdeda6 100644 --- a/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in +++ b/cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in @@ -35,4 +35,4 @@ arrow_keep_backward_compatibility(ArrowFlightSql arrow_flight_sql) check_required_components(ArrowFlightSql) -arrow_show_details(arrow_flight_sql) +arrow_show_details(ArrowFlightSql ARROW_FLIGHT_SQL) diff --git a/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in b/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in index 4a5f6f781a5..b251b86f43e 100644 --- a/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in +++ b/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in @@ -35,4 +35,4 @@ arrow_keep_backward_compatibility(ArrowCUDA arrow_cuda) check_required_components(ArrowCUDA) -arrow_show_details(arrow_cuda) +arrow_show_details(ArrowCUDA ARROW_CUDA) diff --git a/cpp/src/gandiva/GandivaConfig.cmake.in b/cpp/src/gandiva/GandivaConfig.cmake.in index b7fe16fbc8c..c6d7cef73d7 100644 --- a/cpp/src/gandiva/GandivaConfig.cmake.in +++ b/cpp/src/gandiva/GandivaConfig.cmake.in @@ -36,4 +36,4 @@ arrow_keep_backward_compatibility(Gandiva gandiva) check_required_components(Gandiva) -arrow_show_details(gandiva) +arrow_show_details(Gandiva GANDIVA) diff --git a/cpp/src/parquet/ParquetConfig.cmake.in b/cpp/src/parquet/ParquetConfig.cmake.in index f15a4970a9b..10305301388 100644 --- a/cpp/src/parquet/ParquetConfig.cmake.in +++ b/cpp/src/parquet/ParquetConfig.cmake.in @@ -42,4 +42,4 @@ arrow_keep_backward_compatibility(Parquet parquet) check_required_components(Parquet) -arrow_show_details(parquet) +arrow_show_details(Parquet PARQUET) diff --git a/cpp/src/plasma/PlasmaConfig.cmake.in b/cpp/src/plasma/PlasmaConfig.cmake.in index 975f46ba1de..ec3c51ec281 100644 --- a/cpp/src/plasma/PlasmaConfig.cmake.in +++ b/cpp/src/plasma/PlasmaConfig.cmake.in @@ -47,4 +47,4 @@ arrow_keep_backward_compatibility(Plasma plasma) check_required_components(Plasma) -arrow_show_details(plasma) +arrow_show_details(Plasma PLASMA) diff --git a/python/pyarrow/src/ArrowPythonConfig.cmake.in b/python/pyarrow/src/ArrowPythonConfig.cmake.in index a51a66c296a..874c5cc09d1 100644 --- a/python/pyarrow/src/ArrowPythonConfig.cmake.in +++ b/python/pyarrow/src/ArrowPythonConfig.cmake.in @@ -38,4 +38,4 @@ arrow_keep_backward_compatibility(ArrowPython arrow_python) check_required_components(ArrowPython) -arrow_show_details(arrow_python) +arrow_show_details(ArrowPython ARROW_PYTHON) diff --git a/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in b/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in index 3fd57e31211..1aacb9f212d 100644 --- a/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in +++ b/python/pyarrow/src/ArrowPythonFlightConfig.cmake.in @@ -36,4 +36,4 @@ arrow_keep_backward_compatibility(ArrowPythonFlight arrow_python_flight) check_required_components(ArrowPythonFlight) -arrow_show_details(arrow_python_flight) +arrow_show_details(ArrowPythonFlight ARROW_PYTHON_FLIGHT) From 0db0b426b920d5b3d915e2909bed3fcf20925323 Mon Sep 17 00:00:00 2001 From: Dhruv Vats Date: Sun, 11 Sep 2022 19:22:41 +0530 Subject: [PATCH 5/5] ARROW-17632: Revert unintended change --- cpp/examples/minimal_build/CMakeLists.txt | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/cpp/examples/minimal_build/CMakeLists.txt b/cpp/examples/minimal_build/CMakeLists.txt index 2e492f11053..6f4d9cefab4 100644 --- a/cpp/examples/minimal_build/CMakeLists.txt +++ b/cpp/examples/minimal_build/CMakeLists.txt @@ -21,13 +21,7 @@ project(ArrowMinimalExample) option(ARROW_LINK_SHARED "Link to the Arrow shared library" ON) -#find_package(Arrow REQUIRED) -find_package(ArrowCUDA REQUIRED) -find_package(ArrowDataset REQUIRED) -#find_package(ArrowTesting REQUIRED) -find_package(ArrowFlight REQUIRED) -#find_package(ArrowFlightSql REQUIRED) -#find_package(Gandiva REQUIRED) +find_package(Arrow REQUIRED) if(NOT DEFINED CMAKE_CXX_STANDARD) set(CMAKE_CXX_STANDARD 11)