Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45140: [Dev][Release] Release guide improvements #45141

Merged

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Dec 31, 2024

What changes are included in this PR?

Updates to the release guide. Mostly changes to make the guide up to date with how release are being done currently.

Are these changes tested?

Previewed locally.

Are there any user-facing changes?

More accurate docs.

Fixes #45140

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 31, 2024
@amoeba amoeba marked this pull request as ready for review December 31, 2024 20:00
@amoeba amoeba requested review from kou and raulcd December 31, 2024 20:01
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 31, 2024
@amoeba amoeba requested a review from assignUser December 31, 2024 20:01
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

docs/source/developers/release.rst Outdated Show resolved Hide resolved
docs/source/developers/release.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 1, 2025
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/source/developers/release.rst Outdated Show resolved Hide resolved
@assignUser
Copy link
Member

@github-actions crossbow submit preview-docs

Copy link

github-actions bot commented Jan 1, 2025

Revision: 7708605

Submitted crossbow builds: ursacomputing/crossbow @ actions-5732f7a67a

Task Status
preview-docs GitHub Actions

@assignUser
Copy link
Member

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time @amoeba

docs/source/developers/release.rst Outdated Show resolved Hide resolved
docs/source/developers/release.rst Outdated Show resolved Hide resolved
docs/source/developers/release.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jan 7, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 7, 2025
@amoeba
Copy link
Member Author

amoeba commented Jan 7, 2025

Thanks for the reviews all. There's one ongoing discussion still to resolve and I've pushed my latest for re-review.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 7, 2025
@amoeba amoeba merged commit 438cf9b into apache:main Jan 7, 2025
9 checks passed
@amoeba amoeba removed the awaiting changes Awaiting changes label Jan 7, 2025
amoeba added a commit that referenced this pull request Jan 9, 2025
### What changes are included in this PR?

Updates to the release guide. Mostly changes to make the guide up to date with how release are being done currently.

### Are these changes tested?

Previewed locally.

### Are there any user-facing changes?

More accurate docs.

Fixes #45140 
* GitHub Issue: #45140

Lead-authored-by: Bryce Mecum <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
amoeba added a commit that referenced this pull request Jan 11, 2025
### What changes are included in this PR?

Updates to the release guide. Mostly changes to make the guide up to date with how release are being done currently.

### Are these changes tested?

Previewed locally.

### Are there any user-facing changes?

More accurate docs.

Fixes #45140 
* GitHub Issue: #45140

Lead-authored-by: Bryce Mecum <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 438cf9b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev][Release] Review release management guide and release scripts
4 participants