Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Acero] Use implicit_ordering for asof_join rather than require_sequenced_output #44629

Open
EnricoMi opened this issue Nov 3, 2024 · 0 comments

Comments

@EnricoMi
Copy link

EnricoMi commented Nov 3, 2024

Describe the enhancement requested

Changes in #44083 (GH-41706) unnecessarily sequences batches retrieved from scanner where it only requires the batches to provide index according to implicit input order.

Setting implicit_ordering causes existing code to set batch index, which is then available to the asof_join node to sequence the batches int input order. This replaces some of #44083 changes.

Some code introduced by #44083 turns out to not be required and should be reverted.

Component(s)

C++

@kou kou changed the title Use implicit_ordering for asof_join rather than require_sequenced_output [C++][Acero] Use implicit_ordering for asof_join rather than require_sequenced_output Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant