Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Thrift mirrors are outdated #44607

Open
2 tasks
assignUser opened this issue Nov 1, 2024 · 1 comment
Open
2 tasks

[C++] Thrift mirrors are outdated #44607

assignUser opened this issue Nov 1, 2024 · 1 comment
Assignees
Milestone

Comments

@assignUser
Copy link
Member

assignUser commented Nov 1, 2024

Some observations:

  • downloads.apache.org only has archives of Thrift 0.20.0 and 0.21.0 (current latest stable is 0.21.0)
  • Apache appears to now (since 2021?) have a CDN: https://dlcdn.apache.org/thrift/. That also only has archives of 0.20.0 and 0.21.0.

https://apache.org/history/mirror-history.html gives more context and this sentence may explain why this list of URLs degraded over time:

Any organization that has been hosting an Apache download mirror site, and that finds it useful for its own purposes, may continue to host the mirror site.

So I think by continuing to use these mirror URLs we were living on borrowed time. The CDN is now the recommended way for users to download content from ASF projects.

So I think we actually need to do two things here:

  • Change the URL to just use the ASF CDN
  • Update our Thrift version in cpp/thirdparty/versions.txt to 0.20.0 or greater. Arrow C++ builds cleanly on my system when using Brew-provided Thrift 0.21.0 so it seems like this may be doable.

Originally posted by @amoeba in #44523 (comment)

@assignUser assignUser added this to the 18.1.0 milestone Nov 1, 2024
@amoeba amoeba self-assigned this Nov 1, 2024
@amoeba
Copy link
Member

amoeba commented Nov 4, 2024

For extra context here, we originally found this in this CI job as part of pre-submission testing in #44523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants