Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Change the class access modifier of PrimitiveArrayBuilder to public #23995

Open
asfimport opened this issue Feb 3, 2020 · 0 comments · May be fixed by #44596
Open

[C#] Change the class access modifier of PrimitiveArrayBuilder to public #23995

asfimport opened this issue Feb 3, 2020 · 0 comments · May be fixed by #44596

Comments

@asfimport
Copy link
Collaborator

Currently, a user seeking to add a Builder<T> class to their user-defined type in C# can subclass PrimitiveArrayBuilder since it is marked public abstract. However, it's parameterless constructor is marked as internal making it impossible to compile the user's class.

The preferred solution would be to mark this constructor as public. If this cannot be done for some reason, the entire </font><font color="#172b4d">PrimitiveArrayBuilder</font><font color="#172b4d"> class should be marked internal to avoid confusion.

Reporter: Zachary Gramana

Note: This issue was originally created as ARROW-7757. Please see the migration documentation for further details.

filmor added a commit to filmor/arrow that referenced this issue Oct 31, 2024
Fixes apache#23995.

Making this constructor `public` allows for writing custom builders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant