ARROW-1275: [C++] Deafult Snappy static lib suffix updated to "_static"

Author: maxhora

cpp/CMakeLists.txt

@@ -165,7 +165,7 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
   if (MSVC)
     set(BROTLI_MSVC_STATIC_LIB_SUFFIX "_static" CACHE STRING
       "Brotli static lib suffix used on Windows with MSVC (default _static)")
-    set(SNAPPY_MSVC_STATIC_LIB_SUFFIX "" CACHE STRING
+    set(SNAPPY_MSVC_STATIC_LIB_SUFFIX "_static" CACHE STRING
       "Snappy static lib suffix used on Windows with MSVC (default is empty string)")
     set(ZLIB_MSVC_STATIC_LIB_SUFFIX "libstatic" CACHE STRING
       "Zlib static lib suffix used on Windows with MSVC (default libstatic)")

cpp/cmake_modules/SnappyCMakeLists.txt

@@ -68,18 +68,18 @@ set(SNAPPY_SRCS snappy.cc
   snappy-stubs-public.h)
 
 add_library(snappy SHARED ${SNAPPY_SRCS})
-add_library(snappystatic STATIC ${SNAPPY_SRCS})
+add_library(snappy_static STATIC ${SNAPPY_SRCS})
 
 TARGET_COMPILE_DEFINITIONS(snappy PRIVATE -DHAVE_CONFIG_H)
-TARGET_COMPILE_DEFINITIONS(snappystatic PRIVATE -DHAVE_CONFIG_H)
+TARGET_COMPILE_DEFINITIONS(snappy_static PRIVATE -DHAVE_CONFIG_H)
 
 install(FILES snappy.h
   snappy-c.h
   snappy-sinksource.h
   ${snappy_BINARY_DIR}/snappy-stubs-public.h
   DESTINATION include)
 
-install(TARGETS snappy snappystatic
+install(TARGETS snappy snappy_static
   RUNTIME DESTINATION bin
   LIBRARY DESTINATION lib
   ARCHIVE DESTINATION lib)

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -501,7 +501,7 @@ if (ARROW_WITH_SNAPPY)
     set(SNAPPY_HOME "${SNAPPY_PREFIX}")
     set(SNAPPY_INCLUDE_DIR "${SNAPPY_PREFIX}/include")
     if (MSVC)
-      set(SNAPPY_STATIC_LIB_NAME snappystatic)
+      set(SNAPPY_STATIC_LIB_NAME snappy_static)
     else()
       set(SNAPPY_STATIC_LIB_NAME snappy)
     endif()