Skip to content

Automatically retry failed MIRI runs to work around intermittent failures #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Nov 6, 2021
Merged

Automatically retry failed MIRI runs to work around intermittent failures #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c0d52
Move MIRI checks into a shell script
alamb Nov 5, 2021
2ca81ed
add retry loop
alamb Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/miri.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#!/bin/bash
#
# Script
#
# Must be run with nightly rust for example
# rustup default nightly


export MIRIFLAGS="-Zmiri-disable-isolation"
cargo miri setup
cargo clean

run_miri() {
# Currently only the arrow crate is tested with miri
# IO related tests and some unsupported tests are skipped
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
}

# If MIRI fails, automatically retry
# Seems like miri is occasionally killed by the github runner
# https://github.com/apache/arrow-rs/issues/879
for i in `seq 1 5`; do
echo "Starting Arrow MIRI run..."
run_miri && break
echo "foo" > /tmp/data.txt
done
7 changes: 1 addition & 6 deletions .github/workflows/miri.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,4 @@ jobs:
RUST_BACKTRACE: full
RUST_LOG: "trace"
run: |
export MIRIFLAGS="-Zmiri-disable-isolation"
cargo miri setup
cargo clean
# Currently only the arrow crate is tested with miri
# IO related tests and some unsupported tests are skipped
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
bash .github/workflows/miri.sh