-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement eq
comparison for StructArray
#5960
Comments
Here is the relevant error that is happening: Line 236 in 0e56fd5
|
Note that we have a discussion about where to implement comparison for List #5407 The conclusion is that we implement it in datafusion, I have done it already apache/datafusion#11091 If we have the similar configurable null issue for struct, we should also implement it in datafusion. |
Thanks @jayzhan211 -- I didn't know that. If this is a design decision in arrow-rs perhaps we can update the documentation / the error message to make it clear that not only is operation not supported, it will not be (and hint to use make_comparator instead) |
There is docs in |
Ah, thanks I missed that. I will make a PR to improve the error message |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
arrow::compute::kernels::cmp::eq does not support
StructArray
Here is an example
It currenty fails like this:
Describe the solution you'd like
I would like
eq
and the other comparison kernels to support StructArray and the example to passDescribe alternatives you've considered
We can implement comparison downstream via arrow::array::make_comparator as done in apache/datafusion#11117
Additional context
This was reported upstream in datafusion: apache/datafusion#10749
@jayzhan211 added comparison to the dynamic comparator in #5792
The text was updated successfully, but these errors were encountered: