Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize StringView row decoding #5945

Closed
Tracked by #5374
alamb opened this issue Jun 23, 2024 · 2 comments · Fixed by #6044
Closed
Tracked by #5374

Optimize StringView row decoding #5945

alamb opened this issue Jun 23, 2024 · 2 comments · Fixed by #6044
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Jun 23, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Part of #5374

@XiangpengHao implemented row format --> ByteView (StringView / BinaryView) encoding/decoing in https://github.com/apache/arrow-rs/pull/5922/files

Describe the solution you'd like

  1. Add a benchmark for StringView to https://github.com/apache/arrow-rs/blob/master/arrow/benches/row_format.rs
  2. Make the row conversion faster

Describe alternatives you've considered
@tustvold noted that a potential performance improvement https://github.com/apache/arrow-rs/pull/5922/files#r1650032068 -- namely to build the array directly rather than build a StringArray and then convert to StringView

Additional context

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jun 23, 2024
@XiangpengHao
Copy link
Contributor

take, as it seems that decoding string view is taking longer than it should be.

@alamb
Copy link
Contributor Author

alamb commented Jul 24, 2024

label_issue.py automatically added labels {'arrow'} from #6044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants