Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo msrv test is failing on main for object_store #5864

Closed
alamb opened this issue Jun 10, 2024 · 4 comments · Fixed by #5866
Closed

cargo msrv test is failing on main for object_store #5864

alamb opened this issue Jun 10, 2024 · 4 comments · Fixed by #5866
Labels
bug documentation Improvements or additions to documentation parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Jun 10, 2024

Describe the bug
Example:
https://github.com/apache/arrow-rs/actions/runs/9454737839/job/26042972148

Run cargo msrv verify
Fetching index
Verifying the Minimum Supported Rust Version (MSRV) for toolchain x[8](https://github.com/apache/arrow-rs/actions/runs/9454737839/job/26042972148#step:11:9)6_64-unknown-linux-gnu
Using check command cargo check
   Failed check command cargo check didn't succeed
Crate source was found to be incompatible with its MSRV '1.62.1', as defined in '/__w/arrow-rs/arrow-rs/object_store/Cargo.toml'
Error: Process completed with exit code 1.

To Reproduce
Run CI on object_store

Expected behavior

Additional context

@alamb alamb added the bug label Jun 10, 2024
@alamb
Copy link
Contributor Author

alamb commented Jun 10, 2024

started happening with 76d04a8, which was a comment only change

@korowa
Copy link
Contributor

korowa commented Jun 11, 2024

eduard@Aspire-A515-58M:~/projects/arrow-rs/object_store$ cargo msrv --log-target stdout verify
2024-06-11T04:37:08.826187Z  INFO cargo_msrv: initializing cargo_msrv_version="0.15.1"
Fetching index
2024-06-11T04:37:08.826223Z  INFO cargo_msrv: fetching index source="rust-changelog"
2024-06-11T04:37:08.827035Z  INFO cargo_msrv: running action action="verify-msrv"
Verifying the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check
 ⠁                                ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 00:00:00
2024-06-11T04:37:08.828189Z  INFO cargo_msrv::check: ignore_lockfile_enabled=false
2024-06-11T04:37:08.828236Z  INFO download{self=ToolchainDownloader { reporter: toolchain = x86_64-unknown-linux-gnu, cmd = cargo check }}: cargo_msrv::download: installing too
 ⠉ Checking 1.62.1                ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 00:00:00
2024-06-11T04:37:09.343901Z  INFO cargo_msrv::check: try_building run failed toolchain=ToolchainSpec { version: Version { major: 1, minor: 62, patch: 1 }, target: "x86_64-unknown-linux-gnu", spec: OnceCell("1.62.1-x86_64-unknown-linux-gnu") } stderr="error: package `icu_locid_transform v1.5.0` cannot be built because it requires rustc 1.67 or newer, 
   Done Bad check for 1.62.1      ████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 00:00:00
   Failed check command cargo check didn't succeed
Crate source was found to be incompatible with its MSRV '1.62.1', as defined in '/home/eduard/projects/arrow-rs/object_store/Cargo.toml'

Error message may vary (icu_* packages, etc). The reason seems to be this url crate release

@alamb alamb added the documentation Improvements or additions to documentation label Jul 2, 2024
@alamb
Copy link
Contributor Author

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'documentation'} from #5863

@alamb alamb added the parquet Changes to the parquet crate label Jul 2, 2024
@alamb
Copy link
Contributor Author

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'parquet'} from #5863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants