Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary_mut kernel requires both args to be the same type (which is inconsistent with binary) #5818

Closed
alamb opened this issue May 30, 2024 · 2 comments · Fixed by #5833
Closed
Labels
arrow Changes to the arrow crate

Comments

@alamb
Copy link
Contributor

alamb commented May 30, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As part of documenting the _mut compute kernels better in #5798 I noticed in #5798 (comment) thta

binary_mut is inconsistent with binary as it requires both a and b to be the same type of array (where binary can take different types)

Describe the solution you'd like
I would like to have the argument types to binary_mut be different -- so for example, I could write a kernel using binary_mut that took a Float32Array and a Int32Array and added the int32 vale to the float in place.

Describe alternatives you've considered
Leave as is

Additional context
@viirya I think added this API in #3144

@viirya
Copy link
Member

viirya commented May 30, 2024

It's not intentional but just for the usage at the moment. It could be more general to have different types. I can open a PR to do it.

@alamb alamb changed the title binary_mut kernel requires both args to be the same type (which is inconsistent) binary_mut kernel requires both args to be the same type (which is inconsistent with binary) May 30, 2024
@tustvold tustvold added the arrow Changes to the arrow crate label Jun 3, 2024
@tustvold
Copy link
Contributor

tustvold commented Jun 3, 2024

label_issue.py automatically added labels {'arrow'} from #5798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants