Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow Flight format support for StringViewArray and BinaryViewArray #5507

Closed
Tracked by #5374
alamb opened this issue Mar 14, 2024 · 3 comments · Fixed by #5601
Closed
Tracked by #5374

Arrow Flight format support for StringViewArray and BinaryViewArray #5507

alamb opened this issue Mar 14, 2024 · 3 comments · Fixed by #5601
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Mar 14, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is part of the larger project to implement StringViewArray -- see #5374

This ticket tracks adding Arrow Flight support

Describe the solution you'd like
Since Arrow Flight is based on the IPC format, #5506 may be sufficient.

To close this ticket, we should add tests that demonstrate sending / receiving StringViewArray and BinaryViewArray over Arrow flight (e.g. using FlightDataEncoder)

Describe alternatives you've considered

Additional context

@alamb alamb added arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog labels Mar 14, 2024
@alamb alamb changed the title ArrowFlight format support for StringViewArray and BinaryViewArray Arrow Flight format support for StringViewArray and BinaryViewArray Mar 14, 2024
@XiangpengHao
Copy link
Contributor

I can take a look at this (as a way to teach myself some arrow flight knowledge). I have limited bandwidth though, so feel free to bypass me and pushing this forward.

@alamb
Copy link
Contributor Author

alamb commented Apr 1, 2024

Thanks @XiangpengHao -- I think the first thing to do is write a test for StringViewArray and BinaryViewArray for the data encoder/decoder: https://github.com/apache/arrow-rs/blob/master/arrow-flight/tests/encode_decode.rs (I think you can just follow the existing examples)

It may be the case that it "just works" 🙏

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants