Skip to content

Commit 6afa9cf

Browse files
committed
Update examples and tests to use Variant::from instead of Varaint::String
1 parent dbceffa commit 6afa9cf

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

parquet-variant/src/to_json.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ fn write_decimal_i64(
109109
/// ```rust
110110
/// # use parquet_variant::{Variant, variant_to_json};
111111
/// # use arrow_schema::ArrowError;
112-
/// let variant = Variant::String("Hello, World!");
112+
/// let variant = Variant::from("Hello, World!");
113113
/// let mut buffer = Vec::new();
114114
/// variant_to_json(&mut buffer, &variant)?;
115115
/// assert_eq!(String::from_utf8(buffer).unwrap(), "\"Hello, World!\"");
@@ -337,7 +337,7 @@ pub fn variant_to_json_string(variant: &Variant) -> Result<String, ArrowError> {
337337
/// # use parquet_variant::{Variant, variant_to_json_value};
338338
/// # use serde_json::Value;
339339
/// # use arrow_schema::ArrowError;
340-
/// let variant = Variant::String("hello");
340+
/// let variant = Variant::from("hello");
341341
/// let json_value = variant_to_json_value(&variant)?;
342342
/// assert_eq!(json_value, Value::String("hello".to_string()));
343343
/// # Ok::<(), ArrowError>(())
@@ -540,7 +540,7 @@ mod tests {
540540

541541
#[test]
542542
fn test_string_to_json() -> Result<(), ArrowError> {
543-
let variant = Variant::String("hello world");
543+
let variant = Variant::from("hello world");
544544
let json = variant_to_json_string(&variant)?;
545545
assert_eq!(json, "\"hello world\"");
546546

@@ -564,7 +564,7 @@ mod tests {
564564

565565
#[test]
566566
fn test_string_escaping() -> Result<(), ArrowError> {
567-
let variant = Variant::String("hello\nworld\t\"quoted\"");
567+
let variant = Variant::from("hello\nworld\t\"quoted\"");
568568
let json = variant_to_json_string(&variant)?;
569569
assert_eq!(json, "\"hello\\nworld\\t\\\"quoted\\\"\"");
570570

@@ -815,14 +815,14 @@ mod tests {
815815

816816
// Strings
817817
JsonTest {
818-
variant: Variant::String("hello world"),
818+
variant: Variant::from("hello world"),
819819
expected_json: "\"hello world\"",
820820
expected_value: Value::String("hello world".to_string()),
821821
}
822822
.run();
823823

824824
JsonTest {
825-
variant: Variant::String(""),
825+
variant: Variant::from(""),
826826
expected_json: "\"\"",
827827
expected_value: Value::String("".to_string()),
828828
}
@@ -870,14 +870,14 @@ mod tests {
870870
fn test_string_escaping_comprehensive() {
871871
// Test comprehensive string escaping scenarios
872872
JsonTest {
873-
variant: Variant::String("line1\nline2\ttab\"quote\"\\backslash"),
873+
variant: Variant::from("line1\nline2\ttab\"quote\"\\backslash"),
874874
expected_json: "\"line1\\nline2\\ttab\\\"quote\\\"\\\\backslash\"",
875875
expected_value: Value::String("line1\nline2\ttab\"quote\"\\backslash".to_string()),
876876
}
877877
.run();
878878

879879
JsonTest {
880-
variant: Variant::String("Hello 世界 🌍"),
880+
variant: Variant::from("Hello 世界 🌍"),
881881
expected_json: "\"Hello 世界 🌍\"",
882882
expected_value: Value::String("Hello 世界 🌍".to_string()),
883883
}
@@ -888,7 +888,7 @@ mod tests {
888888
fn test_buffer_writing_variants() -> Result<(), ArrowError> {
889889
use crate::variant_to_json;
890890

891-
let variant = Variant::String("test buffer writing");
891+
let variant = Variant::from("test buffer writing");
892892

893893
// Test writing to a Vec<u8>
894894
let mut buffer = Vec::new();

0 commit comments

Comments
 (0)