Update integration test to avoid long format strings #359
+33
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 13, 2025
tustvold
approved these changes
May 13, 2025
Contributor
|
I am facing the same issue. May I ask when a new version will be released to fix this problem? https://github.com/ldclabs/ic-oss/actions/runs/15457272105/job/43511721430 |
Contributor
Author
I am hoping shortly but there is some sort of integration test that needs to be debugged. See the status of the release here If you can spare some help debugging whatever is wrong that would be super helpful |
AdamGS
pushed a commit
to AdamGS/arrow-rs-object-store
that referenced
this pull request
Sep 4, 2025
* Update integration test to avoid long format strings * Update src/integration.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
u16in format string #343Rationale for this change
The new rust release will limit the length of formatting identifiers, so we need to update the tests to create test data using a different mechanism
What changes are included in this PR?
Rewrite test to avoid soon to be unsupported
format!stringsAre there any user-facing changes?
No this is a test only change