feat: expose PyWindowFrame #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing due to new clippy rule in latest Rust. I have a fix in #511 |
|
@dlovell Could you upmerge to pick up the clippy fix? |
|
@andygrove i hadn't heard the term upmerge before, but i presume that means merge |
Yes, exactly. |
andygrove
reviewed
Oct 13, 2023
src/window_frame.rs
Outdated
| "groups" => Some(WindowFrameUnits::Groups), | ||
| _ => None, | ||
| }; | ||
| let units = units.unwrap(); |
There was a problem hiding this comment.
Could we return an Err instead of causing a panic! here?
andygrove
reviewed
Oct 13, 2023
src/window_frame.rs
Outdated
| None => match units { | ||
| WindowFrameUnits::Range => WindowFrameBound::Preceding(ScalarValue::UInt64(None)), | ||
| WindowFrameUnits::Rows => WindowFrameBound::Preceding(ScalarValue::UInt64(None)), | ||
| WindowFrameUnits::Groups => todo!(), |
There was a problem hiding this comment.
Same comment for these todo! calls .. better to return an Err
andygrove
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partial progress on #191 : Expressions: Window function
What changes are included in this PR?
This PR
PyWindowFramefunctions.windowto accept an optionalPyWindowFrameand optionalPySessionContextPySessionContextis necessary to look up aggregates registered viaPySessionContext.register_udaffunction.windowto fall back toSessionContext.udafwhenfind_df_window_funcfailsAccumulatorimpl forRustAccumulatorto exposeretract_batchandsupports_retract_batchAre there any user-facing changes?
PyWindowFrameneeds to be documented as do changes tofunctions.windownote: I have working code that enables window functions for
ibisthat I still need to create a PR for