Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs explaining how to view query plans #373

Merged
merged 2 commits into from
May 8, 2023

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 7, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Start showing off the nice functionality that we have.

What changes are included in this PR?

New section on query plans.

Are there any user-facing changes?

@andygrove andygrove marked this pull request as ready for review May 7, 2023 14:39
@andygrove
Copy link
Member Author

@MrPowers @jdye64 fyi

@MrPowers
Copy link
Contributor

MrPowers commented May 7, 2023

This is so awesome! Well written.

In the future, might be cool to add a section on real-world use cases for this functionality. I'd stress that this is really hard to build from scratch, so many libraries are using the DataFusion query planning capabilities. We could also add a list of the libraries using this functionality. Perhaps we could highlight dask-sql as an example of a success story?

I think the PR is fine as-is and is a great addition to the documentation!

@andygrove
Copy link
Member Author

I think the PR is fine as-is and is a great addition to the documentation!

Thanks. I'll merge this and follow up (likely next weekend) to address your suggestions. The next step is to explain how to inspect the individual operators and expressions (there are Python wrappers for them) and how to transpile to other query engines.

@andygrove andygrove merged commit b8c74a7 into apache:main May 8, 2023
@andygrove andygrove deleted the docs-query-plans branch May 8, 2023 13:50
@jdye64
Copy link
Contributor

jdye64 commented May 8, 2023

Late to the party but this is great @andygrove thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants