Skip to content

Conversation

@shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Jan 22, 2025

Description

Upgrade openresty version to v1.27.1.1.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review February 6, 2025 15:21
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. chore labels Feb 6, 2025
--- error_code: 502
--- error_log
upstream: "grpc://127.0.0.1:80"
connect() failed (111: Connection refused) while connecting to upstream
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is needed as grpc proxy is done under subrequest, and the apisix custom logger (in apisix-nginx-module) overrides the original log handler of nginx and stores the reference to the original log handler in ctx.

but ngx_stash_ctx fails to store reference to that log handler. Thus the original log handler doesn't get executed and the upstream: "grpc: ..." field in error log is not present.

(matched_ssl.value.client.skip_mtls_uri_regex == nil)
local ok, err = ngx_ssl.verify_client(parsed_cert, depth,
-- TODO: support passing `trusted_certs` (3rd arg, keep it nil for now)
local ok, err = ngx_ssl.verify_client(parsed_cert, depth, nil,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the verify client API has changed and it expects 4 parameters now, the 3rd parameter is trusted_certs, we can implement the support for trusted certs later.

@Revolyssup Revolyssup self-requested a review February 6, 2025 15:32
@shreemaan-abhishek shreemaan-abhishek merged commit 346722f into apache:master Feb 10, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants