Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: custom cors header #2340

Closed
zaunist opened this issue Feb 24, 2022 · 1 comment
Closed

Feature request: custom cors header #2340

zaunist opened this issue Feb 24, 2022 · 1 comment

Comments

@zaunist
Copy link
Contributor

zaunist commented Feb 24, 2022

Feature request

Please describe your feature

Currently, manager-api set cors in https://github.com/apache/apisix-dashboard/blob/master/api/internal/filter/cors.go, we should enhance the customization features here to facilitate user-defined configuration of the header.

Describe the solution you'd like

Add a Security configuration field in conf.yaml, so user defined configuration as needed.

Additional context

The cors.go default configuration maybe cause some damage, so we need to fix it.
@zaunist zaunist mentioned this issue Feb 24, 2022
Merged
8 tasks
@zaunist
Copy link
Contributor Author

zaunist commented Mar 14, 2022

#2341 has merged, so close this issue.

@zaunist zaunist closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaunist