Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5501] in_cluster default value in KubernetesPodOperator overwrites configuration #6124

Merged
merged 5 commits into from
Jan 16, 2020

Commits on Sep 23, 2019

  1. [AIRFLOW-5501] Fix in_cluster default in KubernetesPodOperator

    The default value of the parameter in_cluster of the
    kube_client.get_kube_client function is
    in_cluster=conf.getboolean('kubernetes', 'in_cluster'). Therefore, the
    expected behavior is that when, in_cluster is not set, it takes the
    value in the configuration file.
    
    However, the default value of in_cluster in KubernetesPodOperator.py is
    False and in_cluster is passed as a parameter when calling the
    kube_client.get_kube_client function. Therefore, it changes the
    expecting behavior by overwritting the default value. When in_cluster is
    not set when initializing KubernetesPodOperator, the value of in_cluster
    in kube_client.get_kube_client is False and not the value which is in
    the configuration file.
    
    Therefore, the default value of in_cluster in KubernetesPodOperator has
    been changed to None and will not be passed to get_kube_client if it is
    not overwritten so that it takes the configuration value as a default
    value.
    qlemaire22 committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    aaf5013 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Configuration menu
    Copy the full SHA
    8043c49 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Configuration menu
    Copy the full SHA
    048d4bd View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Configuration menu
    Copy the full SHA
    85b49d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Configuration menu
    Copy the full SHA
    9155fb2 View commit details
    Browse the repository at this point in the history