Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 2, 2025

  • Add pause and unpause commands for dags

  • Convert exit in failure

  • Update airflow-ctl/src/airflowctl/ctl/commands/dag_command.py

  • Refactor error message for pause/unpause operations in DAG commands
    (cherry picked from commit 203acbb)

Co-authored-by: Bugra Ozturk [email protected]

@ashb
Copy link
Member

ashb commented Nov 4, 2025

@bugraoz93 I think we need to stop back porting airflowctl changes to the Airflow core release branches. If some part of the process needs this, we need to change that process.

@bugraoz93
Copy link
Contributor

bugraoz93 commented Nov 4, 2025

@bugraoz93 I think we need to stop back porting airflowctl changes to the Airflow core release branches. If some part of the process needs this, we need to change that process.

@ashb I was planning to do it after the first release due to integration test limitations. Leveraging what we have automated backports etc made it easy to use the v3-1-test branch. I assumed it should be fine since the released parts are not even running these code pieces. I wasn't only sure about branch, commit, etc limitations or things to consider which I opened a discussion in Slack in the release channel. I was planning to open as a dev discussion but thought this was a technical detail and we could decide with knowledgeable people. I am not saying everyone should catch the chat or so but just to get an idea or speak out on this backporting case to see if there is big blockers to use it for the first round. I haven't heard hard no, I moved with the backporting option. I already planned this change for sure. As an initial plan, we should definitely release airflowctl from main, that is not questionable

Is it impacting anything in Airflow Core releases? I can speed up the plan if it is causing too much trouble. If we can live with this until the first release, there will be one or two more PRs not more for 0.1.0. This would be very helpful for the first release

@potiuk
Copy link
Member

potiuk commented Nov 4, 2025

I think a pre-requisite for running things from main is indeed adding back-compat tests in CI. Similarly as we do with task-sdk this is something we should definitely do in the future - the plan is to remove EVERYTHING except airlfow-core from v3-* branches eventually and this should be part of it.

If that is something that holds back airflow-ctl release, I would be for merging it now in v3-1-test until we implement back-compat test harness like we have for providers (for both task-sdk and airflow-ctl).

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashb - are you ok with that ?

* Add pause and unpause commands for dags

* Convert exit in failure

* Update airflow-ctl/src/airflowctl/ctl/commands/dag_command.py

* Refactor error message for pause/unpause operations in DAG commands
(cherry picked from commit 203acbb)

Co-authored-by: Bugra Ozturk <[email protected]>
@bugraoz93 bugraoz93 force-pushed the backport-203acbb-v3-1-test branch from 4952e8c to 918906b Compare November 5, 2025 13:45
@potiuk potiuk merged commit 08871ef into v3-1-test Nov 5, 2025
62 checks passed
@potiuk potiuk deleted the backport-203acbb-v3-1-test branch November 5, 2025 15:22
@ashb ashb added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 10, 2025
@ephraimbuddy ephraimbuddy added this to the Airflow 3.1.3 milestone Nov 10, 2025
ephraimbuddy pushed a commit that referenced this pull request Nov 10, 2025
* Add pause and unpause commands for dags

* Convert exit in failure

* Update airflow-ctl/src/airflowctl/ctl/commands/dag_command.py

* Refactor error message for pause/unpause operations in DAG commands
(cherry picked from commit 203acbb)

Co-authored-by: Bugra Ozturk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:airflow-ctl changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants