-
Notifications
You must be signed in to change notification settings - Fork 15.9k
[v3-1-test] Add pause and unpause commands for dags (#57685) #57714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9863d8d to
f56a4aa
Compare
213c76c to
ea401c8
Compare
3d1ae9f to
65d47a1
Compare
f56a4aa to
4952e8c
Compare
|
@bugraoz93 I think we need to stop back porting airflowctl changes to the Airflow core release branches. If some part of the process needs this, we need to change that process. |
@ashb I was planning to do it after the first release due to integration test limitations. Leveraging what we have automated backports etc made it easy to use the v3-1-test branch. I assumed it should be fine since the released parts are not even running these code pieces. I wasn't only sure about branch, commit, etc limitations or things to consider which I opened a discussion in Slack in the release channel. I was planning to open as a dev discussion but thought this was a technical detail and we could decide with knowledgeable people. I am not saying everyone should catch the chat or so but just to get an idea or speak out on this backporting case to see if there is big blockers to use it for the first round. I haven't heard hard no, I moved with the backporting option. I already planned this change for sure. As an initial plan, we should definitely release airflowctl from main, that is not questionable Is it impacting anything in Airflow Core releases? I can speed up the plan if it is causing too much trouble. If we can live with this until the first release, there will be one or two more PRs not more for 0.1.0. This would be very helpful for the first release |
|
I think a pre-requisite for running things from main is indeed adding back-compat tests in CI. Similarly as we do with task-sdk this is something we should definitely do in the future - the plan is to remove EVERYTHING except airlfow-core from v3-* branches eventually and this should be part of it. If that is something that holds back airflow-ctl release, I would be for merging it now in v3-1-test until we implement back-compat test harness like we have for providers (for both task-sdk and airflow-ctl). |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashb - are you ok with that ?
* Add pause and unpause commands for dags * Convert exit in failure * Update airflow-ctl/src/airflowctl/ctl/commands/dag_command.py * Refactor error message for pause/unpause operations in DAG commands (cherry picked from commit 203acbb) Co-authored-by: Bugra Ozturk <[email protected]>
4952e8c to
918906b
Compare
* Add pause and unpause commands for dags * Convert exit in failure * Update airflow-ctl/src/airflowctl/ctl/commands/dag_command.py * Refactor error message for pause/unpause operations in DAG commands (cherry picked from commit 203acbb) Co-authored-by: Bugra Ozturk <[email protected]>
Add pause and unpause commands for dags
Convert exit in failure
Update airflow-ctl/src/airflowctl/ctl/commands/dag_command.py
Refactor error message for pause/unpause operations in DAG commands
(cherry picked from commit 203acbb)
Co-authored-by: Bugra Ozturk [email protected]