Skip to content

Disable GitSync + Persistence combo in the Helm Chart #28822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
potiuk wants to merge 1 commit into from
Closed

Disable GitSync + Persistence combo in the Helm Chart #28822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions chart/newsfragments/28822.significant
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The Chart does not allow to use both dags.persistence and dags.gitSync enabled together. This was a problematic combinations anyway and did not work as intended. The Chart now prevents this combination from being used.
4 changes: 4 additions & 0 deletions chart/templates/check-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,7 @@ The sole purpose of this yaml file is it to check the values file is consistent
{{- end }}

{{- end }}

{{- if and .Values.dags.persistence.enabled .Values.dags.gitSync.enabled }}
{{ required "The combination of dags persistence and gitSync has serious performance and atomicity issues. Choose either gitSync or dags persistence but not the two of them together." nil }}
{{- end }}
1 change: 1 addition & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1813,6 +1813,7 @@ dags:
## optional subpath for dag volume mount
subPath: ~
gitSync:
# Enable git sync sidecar for dags. Cannot be set to True together with dags.persistence.enabled = True
enabled: false

# git repo clone url
Expand Down