Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add "core.task_runner" and "core.enable_xcom_pickling" to unsupported config check to command "airflow config lint" #45214

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Dec 26, 2024

Why

Config core.task_runner and core.enable_xcom_pickling are removed and will no longer exist in airflow 3.0

What

Add lint rules to check these 2 configs

Closes: #45213


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 pending the clarification on xcom pickling, but I am sure you will handle that.
And thanks for code comments for each section, it helps!

@Lee-W Lee-W changed the title feat(cli): add removed "core.task_runner" and "core.enable_xcom_pickling" check to command "airflow config lint" feat(cli): add "core.task_runner" and "core.enable_xcom_pickling" to unsupported config check to command "airflow config lint" Dec 29, 2024
@Lee-W Lee-W force-pushed the extend-airflow-config-lint-rules branch from 4e77a49 to 065730d Compare December 31, 2024 01:25
@potiuk potiuk merged commit abe0bd4 into apache:main Dec 31, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow 2 to 3 auto migration rules - airflow config lint (44080 ~ 45017)
3 participants