Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Set Task Instances State #43752

Open
2 tasks done
omkar-foss opened this issue Nov 6, 2024 · 1 comment · May be fixed by #44246
Open
2 tasks done

AIP-84 Set Task Instances State #43752

omkar-foss opened this issue Nov 6, 2024 · 1 comment · May be fixed by #44246
Assignees
@omkar-foss
Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API kind:feature Feature Requests
Milestone
Airflow 3.0.0

Comments

@omkar-foss
Copy link
Collaborator

omkar-foss commented Nov 6, 2024 •
edited
Loading

Description

Currently the Set Task Instances State public endpoint is at api_connexion/endpoints/task_instance_endpoint.py under post_set_task_instances_state. We need to migrate it to the api_fastapi/views/public/task_instances.py under a set_task_instances_state or similar.

Features and functionality of the endpoint will remain unchanged. Please note that this is a PUT endpoint, contrary to the name of the old API function starting with the word post.

Use case/motivation

AIP-84 cWiki Link: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-84+UI+REST+API

Related issues

Related to: #42370

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@omkar-foss omkar-foss added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Nov 6, 2024
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Nov 6, 2024
@omkar-foss omkar-foss changed the title AIP-84 Post Set Task Instances State AIP-84 Set Task Instances State Nov 6, 2024
@omkar-foss omkar-foss mentioned this issue Nov 6, 2024
Open
1 task
@pierrejeambrun pierrejeambrun removed the needs-triage label for new issues that we didn't triage yet label Nov 6, 2024
@pierrejeambrun pierrejeambrun added the AIP-84 Modern Rest API label Nov 6, 2024
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.0 milestone Nov 6, 2024
@omkar-foss
Copy link
Collaborator Author

I'm working on this one, will raise a PR within today.

@omkar-foss omkar-foss linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omkar-foss omkar-foss

Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API kind:feature Feature Requests
Projects
AIP-84 MODERN REST API
Status: No status
Milestone
Airflow 3.0.0
Development

Successfully merging a pull request may close this issue.

Migrate public endpoint Set Task Instances State to FastAPI omkar-foss/airflow
2 participants
@pierrejeambrun @omkar-foss