Skip to content

Commit b997fee

Browse files
authored
Cleaned up /metaChart and associated code (#47)
* remove metachart endpoint and associated references * cleaned up and removed chartMetaData and associated code from frontend * comment out all metachartdata * merge main * resolve merge conflict * correction of formatting and residues * clean up rebase
1 parent 4a2f3f5 commit b997fee

File tree

9 files changed

+21
-18
lines changed

9 files changed

+21
-18
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ thumb
143143
sketch
144144

145145
### VisualStudioCode ###
146+
.vscode/
146147
.vscode/*
147148
!.vscode/settings.json
148149
!.vscode/tasks.json

backend/src/controllers/databaseController.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class DatabaseController {
6464
throw new Error('Not connected');
6565
}
6666
}
67-
67+
/*
6868
async getMetaChart(req, res, next) {
6969
let databaseService = sessionService.get(req.sessionID);
7070
if (databaseService.isConnected()) {
@@ -88,7 +88,7 @@ class DatabaseController {
8888
} else {
8989
throw new Error('Not connected');
9090
}
91-
}
91+
}*/
9292
}
9393

9494
module.exports = DatabaseController;

backend/src/routes/databaseRouter.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ router.get("/", wrap(databaseController.getStatus));
2727
router.post("/connect", wrap(databaseController.connectDatabase));
2828
router.get("/disconnect", wrap(databaseController.disconnectDatabase));
2929
router.get("/meta", wrap(databaseController.getMetadata));
30-
router.get("/metaChart", wrap(databaseController.getMetaChart));
30+
// router.get("/metaChart", wrap(databaseController.getMetaChart));
3131

3232
module.exports = router;

backend/src/services/databaseService.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class DatabaseService {
6767
}
6868
return metadata;
6969
}
70-
70+
/*
7171
async getGraphLabels() {
7272
let graphRepository = this._graphRepository;
7373
let queryResult = {};
@@ -93,7 +93,7 @@ class DatabaseService {
9393
let queryResult = await graphRepository.execute(query);
9494
9595
return queryResult.rows;
96-
}
96+
}*/
9797

9898
async readMetaData(graphName){
9999
let gr = this._graphRepository;

frontend/src/components/contents/containers/Contents.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919

2020
import { connect } from 'react-redux';
2121
import { getConnectionStatus } from '../../../features/database/DatabaseSlice';
22-
import { getMetaData, getMetaChartData } from '../../../features/database/MetadataSlice';
22+
import { getMetaData/* getMetaChartData */ } from '../../../features/database/MetadataSlice';
2323
import Contents from '../presentations/Contents';
2424

2525
const mapStateToProps = (state) => ({
2626
database: state.database,
2727
isActive: state.navigator.isActive,
2828
});
2929

30-
const mapDispatchToProps = { getConnectionStatus, getMetaData, getMetaChartData };
30+
const mapDispatchToProps = { getConnectionStatus, getMetaData /* getMetaChartData */ };
3131

3232
export default connect(mapStateToProps, mapDispatchToProps)(Contents);

frontend/src/components/contents/presentations/Contents.jsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import FramesContainer from '../containers/Frames';
2424
import styles from './Contents.module.scss';
2525

2626
const Contents = ({
27-
database, isActive, getConnectionStatus, getMetaData, getMetaChartData,
27+
database, isActive, getConnectionStatus, getMetaData, /* getMetaChartData, */
2828
}) => {
2929
const dispatch = useDispatch();
3030

@@ -34,7 +34,7 @@ const Contents = ({
3434
getConnectionStatus().then((response) => {
3535
if (response.type === 'database/getConnectionStatus/fulfilled') {
3636
getMetaData();
37-
getMetaChartData();
37+
/* getMetaChartData(); */
3838
}
3939
});
4040
});
@@ -57,7 +57,7 @@ Contents.propTypes = {
5757
isActive: PropTypes.bool.isRequired,
5858
getConnectionStatus: PropTypes.func.isRequired,
5959
getMetaData: PropTypes.func.isRequired,
60-
getMetaChartData: PropTypes.func.isRequired,
60+
/* getMetaChartData: PropTypes.func.isRequired, */
6161
};
6262

6363
export default Contents;

frontend/src/components/frame/containers/ServerConnectContainer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
import { connect } from 'react-redux';
2121
import { connectToDatabase } from '../../../features/database/DatabaseSlice';
22-
import { getMetaChartData, getMetaData } from '../../../features/database/MetadataSlice';
22+
import { /* getMetaChartData, */ getMetaData } from '../../../features/database/MetadataSlice';
2323
import {
2424
addFrame, pinFrame, removeFrame, trimFrame,
2525
} from '../../../features/frame/FrameSlice';
@@ -36,7 +36,7 @@ const mapDispatchToProps = {
3636
pinFrame,
3737
addAlert,
3838
getMetaData,
39-
getMetaChartData,
39+
/* getMetaChartData, */
4040
};
4141

4242
export default connect(mapStateToProps, mapDispatchToProps)(ServerConnectFrame);

frontend/src/components/frame/presentations/ServerConnectFrame.jsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import styles from './ServerConnectFrame.module.scss';
2929
import { connectToDatabase as connectToDatabaseApi, changeGraph } from '../../../features/database/DatabaseSlice';
3030
import { addAlert } from '../../../features/alert/AlertSlice';
3131
import { addFrame, trimFrame } from '../../../features/frame/FrameSlice';
32-
import { getMetaChartData, getMetaData } from '../../../features/database/MetadataSlice';
32+
import { /* getMetaChartData, */ getMetaData } from '../../../features/database/MetadataSlice';
3333

3434
const FormInitialValue = {
3535
database: '',
@@ -54,9 +54,10 @@ const ServerConnectFrame = ({
5454
dispatch(getMetaData()).then((metadataResponse) => {
5555
if (metadataResponse.type === 'database/getMetaData/fulfilled') {
5656
const graphName = Object.keys(metadataResponse.payload)[0];
57-
dispatch(getMetaChartData());
57+
/* dispatch(getMetaChartData()); */
5858
dispatch(changeGraph({ graphName }));
59-
} else if (metadataResponse.type === 'database/getMetaData/rejected') {
59+
}
60+
if (metadataResponse.type === 'database/getMetaData/rejected') {
6061
dispatch(addAlert('ErrorMetaFail'));
6162
}
6263
});

frontend/src/features/database/MetadataSlice.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const getMetaData = createAsyncThunk(
5454
}
5555
},
5656
);
57-
57+
/*
5858
export const getMetaChartData = createAsyncThunk(
5959
'database/getMetaChartData',
6060
async () => {
@@ -74,6 +74,7 @@ export const getMetaChartData = createAsyncThunk(
7474
}
7575
},
7676
);
77+
*/
7778

7879
const MetadataSlice = createSlice({
7980
name: 'metadata',
@@ -108,12 +109,12 @@ const MetadataSlice = createSlice({
108109
dbname: action.payload.database,
109110
};
110111
},
111-
[getMetaChartData.fulfilled]: (state, action) => {
112+
/* [getMetaChartData.fulfilled]: (state, action) => {
112113
if (action.payload) {
113114
return Object.assign(state, { rows: action.payload });
114115
}
115116
return Object.assign(state, { rows: [] });
116-
},
117+
}, */
117118
},
118119
});
119120

0 commit comments

Comments
 (0)