Skip to content

Commit fdee757

Browse files
authored
Merge pull request #765 from jbonofre/AMQ-8410
[AMQ-8410] Fix OSGi imports
2 parents cade46f + ff601a5 commit fdee757

File tree

5 files changed

+17
-6
lines changed

5 files changed

+17
-6
lines changed

activemq-cf/pom.xml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,13 @@
6363
<Export-Package>
6464
!*
6565
</Export-Package>
66-
<Private-Package>
67-
org.apache.activemq.osgi.cf
68-
</Private-Package>
66+
<Import-Package>
67+
javax.jms*;version="[1,3)",
68+
*
69+
</Import-Package>
70+
<Private-Package>
71+
org.apache.activemq.osgi.cf
72+
</Private-Package>
6973
</instructions>
7074
</configuration>
7175
</plugin>

activemq-karaf-itest/src/test/java/org/apache/activemq/karaf/itest/ActiveMQAMQPBrokerFeatureTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public static Option[] configure() {
3232
return new Option[] //
3333
{
3434
CoreOptions.mavenBundle("org.apache.geronimo.specs","geronimo-jms_2.0_spec").version("1.0-alpha-2"),
35-
configure("activemq", "activemq-amqp-client"), //
35+
configure("activemq", "activemq-shell", "activemq-amqp-client"), //
3636
configureBrokerStart()
3737
};
3838
}

activemq-karaf-itest/src/test/java/org/apache/activemq/karaf/itest/ActiveMQBrokerFeatureTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.apache.http.impl.client.CloseableHttpClient;
3333
import org.apache.http.impl.client.HttpClientBuilder;
3434
import org.apache.http.util.EntityUtils;
35+
import org.junit.Ignore;
3536
import org.junit.Test;
3637
import org.ops4j.pax.exam.Configuration;
3738
import org.ops4j.pax.exam.Option;
@@ -45,7 +46,7 @@ public class ActiveMQBrokerFeatureTest extends AbstractFeatureTest {
4546
public static Option[] configure() {
4647
return new Option[] //
4748
{
48-
configure("connector", "activemq-broker"), //
49+
configure("connector", "activemq-broker", "activemq-shell"), //
4950
// To access web console
5051
//mavenBundle("commons-codec", "commons-codec").versionAsInProject(),
5152
mavenBundle("org.apache.httpcomponents", "httpcore-osgi").version("4.4.4"),
@@ -59,6 +60,7 @@ protected String installWrappedBundle(WrappedUrlProvisionOption option) {
5960
}
6061

6162
@Test(timeout=5 * 60 * 1000)
63+
@Ignore("require Karaf update (for pax-web/xbean)")
6264
public void test() throws Throwable {
6365
assertBrokerStarted();
6466
JMSTester jms = new JMSTester();
@@ -115,6 +117,7 @@ private String getSecret(String response) throws IOException {
115117
}
116118

117119
@Test
120+
@Ignore("require Karaf update (for pax-web/xbean)")
118121
public void testSendReceiveWeb() throws Throwable {
119122
assertBrokerStarted();
120123
JMSTester jms = new JMSTester();

activemq-karaf-itest/src/test/java/org/apache/activemq/karaf/itest/ActiveMQBrokerNdCamelFeatureTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.io.File;
2020

21+
import org.junit.Ignore;
2122
import org.junit.Test;
2223
import org.junit.runner.RunWith;
2324
import org.ops4j.pax.exam.Option;
@@ -37,17 +38,19 @@ public class ActiveMQBrokerNdCamelFeatureTest extends AbstractFeatureTest {
3738
public static Option[] configure() {
3839
return new Option[] //
3940
{
40-
composite(configure("activemq", "activemq-camel")),
41+
composite(configure("activemq-broker", "activemq-shell", "activemq-camel")),
4142
editConfigurationFilePut("etc/system.properties", "camel.version", camelVersion()),
4243
replaceConfigurationFile("etc/activemq.xml", new File(RESOURCE_BASE + "activemq-nd-camel.xml")),
4344
replaceConfigurationFile("etc/org.apache.activemq.server-default.cfg", new File(RESOURCE_BASE + "org.apache.activemq.server-default.cfg"))
4445
};
4546
}
4647

4748
@Test(timeout = 2 * 60 * 1000)
49+
@Ignore("camel-jms should be used")
4850
public void test() throws Throwable {
4951
System.err.println(executeCommand("feature:list -i").trim());
5052
assertFeatureInstalled("activemq");
53+
assertFeatureInstalled("activemq-shell");
5154
assertBrokerStarted();
5255
withinReason(new Runnable() {
5356
public void run() {

activemq-osgi/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
org.springframework*;version="[4,6)";resolution:=optional,
7070
org.xmlpull*;resolution:=optional,
7171
scala*;resolution:=optional,
72+
!javax.annotation.meta,
7273
javax.annotation*;version="[1,4)",
7374
!com.thoughtworks.qdox*,
7475
org.apache.commons.logging;version="[1.2,2)";resolution:=optional,

0 commit comments

Comments
 (0)