fix(legacy-table): linting errors

Author: ktmud

packages/superset-ui-legacy-plugin-chart-pivot-table/README.md

@@ -7,17 +7,18 @@ This plugin provides Pivot Table for Superset.
 
 ### Usage
 
-Configure `key`, which can be any `string`, and register the plugin. This `key` will be used to lookup this chart throughout the app.
+Configure `key`, which can be any `string`, and register the plugin. This `key` will be used to
+lookup this chart throughout the app.
 
 ```js
 import PivottableChartPlugin from '@superset-ui/legacy-plugin-chart-pivot-table';
 
-new PivottableChartPlugin()
-  .configure({ key: 'pivot-table' })
-  .register();
+new PivottableChartPlugin().configure({ key: 'pivot-table' }).register();
 ```
 
-Then use it via `SuperChart`. See [storybook](https://apache-superset.github.io/superset-ui-plugins/?selectedKind=plugin-chart-pivot-table) for more details.
+Then use it via `SuperChart`. See
+[storybook](https://apache-superset.github.io/superset-ui-plugins/?selectedKind=plugin-chart-pivot-table)
+for more details.
 
 ```js
 <SuperChart
@@ -29,4 +30,4 @@ Then use it via `SuperChart`. See [storybook](https://apache-superset.github.io/
     data: {...},
   }}
 />
-```
+```

packages/superset-ui-legacy-plugin-chart-table/package.json

@@ -41,6 +41,7 @@
     "@superset-ui/time-format": "^0.12.0",
     "@superset-ui/translation": "^0.12.0",
     "jquery": "^3.4.1",
-    "react": "^16.8.0"
+    "react": "^16.8.0",
+    "react-dom": "^16.8.0"
   }
 }

packages/superset-ui-legacy-plugin-chart-table/src/ReactDataTable.tsx

@@ -252,9 +252,9 @@ export default function ReactDataTable(props: DataTableProps) {
 
   return (
     <div
+      dangerouslySetInnerHTML={{ __html: ReactDOMServer.renderToStaticMarkup(tableElement) }}
       ref={rootElem}
       className="superset-legacy-chart-table"
-      dangerouslySetInnerHTML={{ __html: ReactDOMServer.renderToStaticMarkup(tableElement) }}
     />
   );
 }

scripts/build.js

@@ -7,14 +7,18 @@ const glob = process.argv[2];
 
 process.env.PATH = `./node_modules/.bin:${process.env.PATH}`;
 
-const run = (cmd, async = false) => {
+const run = (cmd) => {
   console.log(`>> ${cmd}`);
   const [p, ...args] = cmd.split(' ');
-  const runner = async ? spawn : spawnSync;
-  runner(p, args, { stdio: 'inherit' });
+  const runner = spawnSync;
+  const { status } = runner(p, args, { stdio: 'inherit' });
+  if (status !== 0) {
+    process.exit(status);
+  }
 };
 
 if (glob) {
+  run(`eslint --color --quiet packages/${glob}/{src,test}/**/*.{js,jsx,ts,tsx}`);
   run(`nimbus prettier --check --workspaces=\"@superset-ui/${glob}"`);
   run(`nimbus babel --clean --workspaces=\"@superset-ui/${glob}"`);
   run(`nimbus babel --clean --workspaces=\"@superset-ui/${glob}" --esm`);