This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 118
Submission client redesign to use a step-based builder pattern #365
Merged
Commits on Jul 5, 2017
-
Submission client redesign to use a step-based builder pattern.
This change overhauls the underlying architecture of the submission client, but it is intended to entirely preserve existing behavior of Spark applications. Therefore users will find this to be an invisible change. The philosophy behind this design is to reconsider the breakdown of the submission process. It operates off the abstraction of "submission steps", which are transformation functions that take the previous state of the driver and return the new state of the driver. The driver's state includes its Spark configurations and the Kubernetes resources that will be used to deploy it. Such a refactor moves away from a features-first API design, which considers different containers to serve a set of features. The previous design, for example, had a container files resolver API object that returned different resolutions of the dependencies added by the user. However, it was up to the main Client to know how to intelligently invoke all of those APIs. Therefore the API surface area of the file resolver became untenably large and it was not intuitive of how it was to be used or extended. This design changes the encapsulation layout; every module is now responsible for changing the driver specification directly. An orchestrator builds the correct chain of steps and hands it to the client, which then calls it verbatim. The main client then makes any final modifications that put the different pieces of the driver together, particularly to attach the driver container itself to the pod and to apply the Spark configuration as command-line arguments.
Configuration menu - View commit details
-
Copy full SHA for 9ff8c69 - Browse repository at this point
Copy the full SHA 9ff8c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for c23bb4c - Browse repository at this point
Copy the full SHA c23bb4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d28b8 - Browse repository at this point
Copy the full SHA f8d28b8View commit details
Commits on Jul 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 90f77fb - Browse repository at this point
Copy the full SHA 90f77fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01b8d18 - Browse repository at this point
Copy the full SHA 01b8d18View commit details -
Configuration menu - View commit details
-
Copy full SHA for db1f0c2 - Browse repository at this point
Copy the full SHA db1f0c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20d9a90 - Browse repository at this point
Copy the full SHA 20d9a90View commit details -
Merge branch 'submission-steps-refactor' of https://github.com/apache…
…-spark-on-k8s/spark into submission-steps-refactor
Configuration menu - View commit details
-
Copy full SHA for 1fb49a0 - Browse repository at this point
Copy the full SHA 1fb49a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11c95e9 - Browse repository at this point
Copy the full SHA 11c95e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a186d - Browse repository at this point
Copy the full SHA 80a186dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f58411 - Browse repository at this point
Copy the full SHA 1f58411View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31985a6 - Browse repository at this point
Copy the full SHA 31985a6View commit details
Commits on Jul 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9e002aa - Browse repository at this point
Copy the full SHA 9e002aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a7561 - Browse repository at this point
Copy the full SHA 61a7561View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa78aad - Browse repository at this point
Copy the full SHA fa78aadView commit details -
Configuration menu - View commit details
-
Copy full SHA for c477a0c - Browse repository at this point
Copy the full SHA c477a0cView commit details
Commits on Jul 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5a76328 - Browse repository at this point
Copy the full SHA 5a76328View commit details -
Merge branch 'submission-steps-refactor' of github.com:apache-spark-o…
…n-k8s/spark into submission-steps-refactor
Configuration menu - View commit details
-
Copy full SHA for 16adf71 - Browse repository at this point
Copy the full SHA 16adf71View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed52eee - Browse repository at this point
Copy the full SHA ed52eeeView commit details -
Attempt to make spacing consistent.
Multi-line methods should have four-space indentation for arguments that aren't on the same line as the method call itself... but this is difficult to do consistently given how IDEs handle Scala multi-line indentation in most cases.
Configuration menu - View commit details
-
Copy full SHA for 397312c - Browse repository at this point
Copy the full SHA 397312cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.