This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
allow spark driver find shuffle pods in specified namespace #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conf property spark.kubernetes.shuffle.namespace is used to
specify the namesapce of shuffle pods.
In normal cases, only one "shuffle daemonset" is deployed and
shared by all spark pods.
The spark driver should be able to list and watch shuffle pods
in the namespace specified by user.
Note: by default, spark driver pod doesn't have authority to
list and watch shuffle pods in another namespace. Some action
is needed to grant it the authority. For example, below ABAC
policy works.
```
{"apiVersion": "abac.authorization.kubernetes.io/v1beta1", "kind":
"Policy", "spec": {"group": "system:serviceaccounts", "namespace":
"SHUFFLE_NAMESPACE",
"resource": "pods", "readonly": true}}
```
|
Thanks for the PR @honkiko. This LGTM. |
foxish
approved these changes
Jun 22, 2017
|
Thanks for the contribution @honkiko ! We're always happy to see new names in this project. It looks like you're fixing a bug here, given that the |
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
The conf property spark.kubernetes.shuffle.namespace is used to
specify the namesapce of shuffle pods.
In normal cases, only one "shuffle daemonset" is deployed and
shared by all spark pods.
The spark driver should be able to list and watch shuffle pods
in the namespace specified by user.
Note: by default, spark driver pod doesn't have authority to
list and watch shuffle pods in another namespace. Some action
is needed to grant it the authority. For example, below ABAC
policy works.
```
{"apiVersion": "abac.authorization.kubernetes.io/v1beta1", "kind":
"Policy", "spec": {"group": "system:serviceaccounts", "namespace":
"SHUFFLE_NAMESPACE",
"resource": "pods", "readonly": true}}
```
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
…park-on-k8s#357) The conf property spark.kubernetes.shuffle.namespace is used to specify the namesapce of shuffle pods. In normal cases, only one "shuffle daemonset" is deployed and shared by all spark pods. The spark driver should be able to list and watch shuffle pods in the namespace specified by user. Note: by default, spark driver pod doesn't have authority to list and watch shuffle pods in another namespace. Some action is needed to grant it the authority. For example, below ABAC policy works. ``` {"apiVersion": "abac.authorization.kubernetes.io/v1beta1", "kind": "Policy", "spec": {"group": "system:serviceaccounts", "namespace": "SHUFFLE_NAMESPACE", "resource": "pods", "readonly": true}} ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conf property spark.kubernetes.shuffle.namespace is used to
specify the namesapce of shuffle pods.
In normal cases, only one "shuffle daemonset" is deployed and
shared by all spark pods.
The spark driver should be able to list and watch shuffle pods
in the namespace specified by user.
Note: by default, spark driver pod doesn't have authority to
list and watch shuffle pods in another namespace. Some action
is needed to grant it the authority. For example, below ABAC
policy works.
What changes were proposed in this pull request?
allow spark driver find shuffle pods in specified namespace
How was this patch tested?
tested by example SparkPi.