Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Commit

Permalink
settings(nfc): Remove NFC beam settings
Browse files Browse the repository at this point in the history
This API was already deprecated and not supported for a few years. The
API was completely removed in Android U (see b/236980291).

Bug: 307352220
Test: Verified NFC settings works correctly
Merged-In: I40974a26d170cf3eeec18e6a07a21f6c420eca9e
Change-Id: I40974a26d170cf3eeec18e6a07a21f6c420eca9e
  • Loading branch information
rpius committed Oct 30, 2023
1 parent 5abd342 commit ad565c4
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 534 deletions.
17 changes: 0 additions & 17 deletions AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3017,23 +3017,6 @@
</intent-filter>
</activity>

<!-- NFC settings -->
<activity
android:name="Settings$AndroidBeamSettingsActivity"
android:exported="true"
android:label="@string/android_beam_settings_title">
<intent-filter android:priority="1">
<action android:name="android.settings.NFCSHARING_SETTINGS" />
<category android:name="android.intent.category.DEFAULT" />
</intent-filter>
<meta-data android:name="com.android.settings.FRAGMENT_CLASS"
android:value="com.android.settings.nfc.AndroidBeam" />
<meta-data android:name="com.android.settings.HIGHLIGHT_MENU_KEY"
android:value="@string/menu_key_connected_devices"/>
<meta-data android:name="com.android.settings.PRIMARY_PROFILE_CONTROLLED"
android:value="true" />
</activity>

<activity
android:name="Settings$WifiDisplaySettingsActivity"
android:label="@string/wifi_display_settings_title"
Expand Down
8 changes: 0 additions & 8 deletions res/xml/connected_devices_advanced.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,6 @@
settings:controller="com.android.settings.wfd.WifiDisplayPreferenceController"
settings:keywords="@string/keywords_wifi_display_settings"/>

<com.android.settingslib.RestrictedPreference
android:fragment="com.android.settings.nfc.AndroidBeam"
android:key="android_beam_settings"
android:title="@string/android_beam_settings_title"
settings:controller="com.android.settings.nfc.AndroidBeamPreferenceController"
android:icon="@drawable/ic_android"
android:order="-5"/>

<com.android.settingslib.RestrictedPreference
android:key="connected_device_printing"
android:title="@string/print_settings"
Expand Down
1 change: 0 additions & 1 deletion src/com/android/settings/Settings.java
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ public static class MobileDataUsageListActivity extends SettingsActivity { /* em
public static class ConfigureWifiSettingsActivity extends SettingsActivity { /* empty */ }
public static class SavedAccessPointsSettingsActivity extends SettingsActivity { /* empty */ }
public static class TextToSpeechSettingsActivity extends SettingsActivity { /* empty */ }
public static class AndroidBeamSettingsActivity extends SettingsActivity { /* empty */ }
public static class WifiDisplaySettingsActivity extends SettingsActivity { /* empty */ }
public static class DreamSettingsActivity extends SettingsActivity { /* empty */ }
/** Activity to manage communal settings */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@

import android.app.settings.SettingsEnums;
import android.content.Context;
import android.content.pm.PackageManager;
import android.provider.SearchIndexableResource;

import com.android.settings.R;
import com.android.settings.dashboard.DashboardFragment;
import com.android.settings.nfc.AndroidBeamPreferenceController;
import com.android.settings.print.PrintSettingPreferenceController;
import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settings.uwb.UwbPreferenceController;
Expand Down Expand Up @@ -111,17 +109,6 @@ public List<SearchIndexableResource> getXmlResourcesToIndex(
return Arrays.asList(sir);
}

@Override
public List<String> getNonIndexableKeys(Context context) {
final List<String> keys = super.getNonIndexableKeys(context);
PackageManager pm = context.getPackageManager();
if (!pm.hasSystemFeature(PackageManager.FEATURE_NFC)) {
keys.add(AndroidBeamPreferenceController.KEY_ANDROID_BEAM_SETTINGS);
}

return keys;
}

@Override
public List<AbstractPreferenceController> createPreferenceControllers(
Context context) {
Expand Down
2 changes: 0 additions & 2 deletions src/com/android/settings/core/gateway/SettingsGateway.java
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@
import com.android.settings.network.telephony.MobileNetworkSettings;
import com.android.settings.network.telephony.NetworkSelectSettings;
import com.android.settings.network.tether.TetherSettings;
import com.android.settings.nfc.AndroidBeam;
import com.android.settings.nfc.PaymentSettings;
import com.android.settings.notification.ConfigureNotificationSettings;
import com.android.settings.notification.NotificationAccessSettings;
Expand Down Expand Up @@ -258,7 +257,6 @@ public class SettingsGateway {
PrivateVolumeForget.class.getName(),
PublicVolumeSettings.class.getName(),
DevelopmentSettingsDashboardFragment.class.getName(),
AndroidBeam.class.getName(),
WifiDisplaySettings.class.getName(),
PowerUsageSummary.class.getName(),
AccountSyncSettings.class.getName(),
Expand Down
148 changes: 0 additions & 148 deletions src/com/android/settings/nfc/AndroidBeam.java

This file was deleted.

79 changes: 0 additions & 79 deletions src/com/android/settings/nfc/AndroidBeamEnabler.java

This file was deleted.

Loading

0 comments on commit ad565c4

Please sign in to comment.