Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] If a folder which is to be extracted already exists, the number appended to the folder name starts at 3, not 2 #1537

Closed
OnesuchDev opened this issue Oct 24, 2024 · 3 comments

Comments

@OnesuchDev
Copy link

OnesuchDev commented Oct 24, 2024

Configuration

  • Keka version: 1.4.4
  • macOS version: 14.7 (23H124)

Describe the bug

If a folder which is to be extracted already exists, the number appended to the folder name starts at 3, not 2.
This was working correctly quite a while ago, but I'm not sure exactly what version of Keka broke it.

To Reproduce

Steps to reproduce the behavior:

  1. Extract an archive which creates a folder, say, "folder"
  2. Extract the same archive again to the same folder
  3. Observe that the resulting folder is named "folder 3" instead of "folder 2"

Expected behavior

The resulting folder is named "folder 2".

Additional context

Keka has Full Disk Access permissions.

@OnesuchDev OnesuchDev added the bug label Oct 24, 2024
@OnesuchDev OnesuchDev changed the title [BUG] If a folder which is to be extracted already exists, the resulting folder is renamed to end with 3 instead of 2 [BUG] If a folder which is to be extracted already exists, the number appended to the folder name starts at 3, not 2 Oct 24, 2024
@aonez aonez added this to the macOS-1.4.6 milestone Oct 24, 2024
@aonez
Copy link
Owner

aonez commented Oct 24, 2024

Thanks @OnesuchDev. Checked this out and turns out it's like this since v1.3.0 (06/2023), worked properly in v1.2.61. The bug was introduced since there was a redesign of the naming code in this v1.3.0 change:

  • Enhanced extraction naming with multiple extensions

Sadly just released v1.4.5 so this fix will be available in a few weeks since it is not critical.

But already published a fixed build that you can use as your daily driver:
https://github.com/aonez/Keka/releases/download/dev-test-builds/Keka-v1.4.6.r5512.7z

@OnesuchDev
Copy link
Author

OnesuchDev commented Oct 24, 2024 via email

@aonez
Copy link
Owner

aonez commented Nov 27, 2024

v1.4.7 is public now. Thanks again @OnesuchDev.

@aonez aonez closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants