Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] LZ4 v1.10.0 support #1496

Closed
YunsuChoi opened this issue Aug 6, 2024 · 2 comments
Closed

[REQ] LZ4 v1.10.0 support #1496

YunsuChoi opened this issue Aug 6, 2024 · 2 comments

Comments

@YunsuChoi
Copy link

Since 2024. 6. 18, Keka added support lz4 compression and decompression.
after then lz4 finally supports multicore mode at version 1.10.0 and it boosts performance from 5x to 10x.
Therefore, please consider upgrade lz4 core to latest version. thanks.

@aonez aonez added the core label Aug 6, 2024
@aonez aonez added this to the macOS-1.4.4 milestone Aug 6, 2024
@aonez
Copy link
Owner

aonez commented Aug 13, 2024

Not sure if I'm missing something here but the current version used in Keka (v1.9.4) already has multithread support and Keka integrates and uses it. I did some test comparing it to v1.10.0 and speeds and processor use is similar if not the same.

aone@aONe-Pro Desktop % /Applications/Keka.app/Contents/MacOS/Keka --cli lz4 -h
*** lz4 v1.9.5 64-bit multithread, by Yann Collet ***

@aonez
Copy link
Owner

aonez commented Aug 13, 2024

Just posting this it's clear to me that I've used a code between 1.9.4 and 1.10.0, dubbed 1.9.5. This code most probably already had multithread support. I'll update to 1.10.0 nonetheless.

@aonez aonez added the fixed label Aug 13, 2024
@aonez aonez closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants