Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization update (ja-jp) #1475

Closed
wants to merge 4 commits into from
Closed

Localization update (ja-jp) #1475

wants to merge 4 commits into from

Conversation

tedSw
Copy link
Contributor

@tedSw tedSw commented Jun 24, 2024

iOS : Localize add and update (pointed out items)
macOS : Localize update (untranslated strings and translation mistakes)

All repositories have been reacquired and worked on since the last commit

tedSw and others added 3 commits June 20, 2024 05:30
add new Localizable strings for update
iOS : Localize add and update (pointed out items)
macOS : Localize update  (untranslated strings and translation mistakes)
This reverts commit 7a0c6a5, reversing
changes made to 6d3717f.
aonez added a commit that referenced this pull request Jun 25, 2024
@aonez aonez added this to the macOS-1.4.2 milestone Jun 25, 2024
@aonez
Copy link
Owner

aonez commented Jun 25, 2024

Hi @tedSw! Thank you so much for your contribution 🤩

I'm sorry but there were some issues with this pull again. I've tried fixing them to merge but it got worse.

I've merged them manually here: d707202
All your changes should be there, so no problem at all 🙌

A few tips for future pulls:

  • For iOS only translate the xcloc OR the Alternative-Strings-Files. Just choose your preferred one.
  • For macOS do NOT translate any HTML file. Those are generated automatically using the strings files.
  • For macOS once you're done with your changes execute the script convert. This will fix some encoding issues that prevent the strings files to be treated as is.

You can also send me the files via mail at [email protected] if you prefer. But I'm sure the next time the pull will be merged without issues.

@aonez aonez closed this Jun 25, 2024
aonez added a commit that referenced this pull request Jun 25, 2024
@tedSw there were some changes between your xcloc and strings files. I've used the xcloc because is the preferred file for updating the translations.
#1475
d707202
@tedSw
Copy link
Contributor Author

tedSw commented Jun 25, 2024

@aonez
Thanks manually merge and I apologize for the inconvenience
I respect your annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants