Skip to content

Commit c3bcbd5

Browse files
mielpeetersaome510
andauthored
fix image border (#613)
Co-authored-by: Thang Pham <[email protected]>
1 parent bab9196 commit c3bcbd5

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

Diff for: spotify_player/src/ui/playback.rs

+15-5
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,12 @@ pub fn render_playback_window(
8282
if needs_clear {
8383
// clear the image's both new and old areas to ensure no remaining artifacts before rendering the image
8484
// See: https://github.com/aome510/spotify-player/issues/389
85-
clear_area(frame, ui.last_cover_image_render_info.render_area);
86-
clear_area(frame, cover_img_rect);
85+
clear_area(
86+
frame,
87+
ui.last_cover_image_render_info.render_area,
88+
&ui.theme,
89+
);
90+
clear_area(frame, cover_img_rect, &ui.theme);
8791
} else {
8892
if !ui.last_cover_image_render_info.rendered {
8993
if let Err(err) = render_playback_cover_image(state, ui) {
@@ -144,7 +148,11 @@ pub fn render_playback_window(
144148
#[cfg(feature = "image")]
145149
{
146150
if ui.last_cover_image_render_info.rendered {
147-
clear_area(frame, ui.last_cover_image_render_info.render_area);
151+
clear_area(
152+
frame,
153+
ui.last_cover_image_render_info.render_area,
154+
&ui.theme,
155+
);
148156
ui.last_cover_image_render_info = ImageRenderInfo::default();
149157
}
150158
}
@@ -164,14 +172,15 @@ pub fn render_playback_window(
164172
}
165173

166174
#[cfg(feature = "image")]
167-
fn clear_area(frame: &mut Frame, rect: Rect) {
175+
fn clear_area(frame: &mut Frame, rect: Rect, theme: &config::Theme) {
168176
for x in rect.left()..rect.right() {
169177
for y in rect.top()..rect.bottom() {
170178
frame
171179
.buffer_mut()
172180
.cell_mut((x, y))
173181
.expect("invalid cell")
174-
.reset();
182+
.set_char(' ')
183+
.set_style(theme.app());
175184
}
176185
}
177186
}
@@ -373,6 +382,7 @@ fn render_playback_cover_image(state: &SharedState, ui: &mut UIStateGuard) -> Re
373382
width: Some(width),
374383
height: Some(height),
375384
restore_cursor: true,
385+
transparent: true,
376386
..Default::default()
377387
},
378388
)

0 commit comments

Comments
 (0)