Add fixed-point codecs#1568
Merged
Merged
Conversation
This was referenced Apr 24, 2026
Merged
|
This was referenced Apr 24, 2026
Member
Author
BundleMonFiles updated (4)
Unchanged files (143)
Total files change +3.98KB +0.77% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-7aa2o4lfp-anza-tech.vercel.app |
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
08d6604 to
9a22f6a
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_string_and_number_conversions
branch
from
dec9bf6 to
8e377fb
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
9a22f6a to
a6469c7
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_string_and_number_conversions
branch
from
8e377fb to
89cd89f
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_string_and_number_conversions
branch
from
89cd89f to
f97f875
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
a6469c7 to
82550ec
Compare
mcintyre94
approved these changes
May 4, 2026
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Nice, this implementation looks great!
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
82550ec to
a49dee0
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_string_and_number_conversions
branch
2 times, most recently
from
2031a98 to
ec8d8d1
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
a49dee0 to
6f5b036
Compare
Member
Author
Merge activity
|
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
6f5b036 to
e95504c
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_string_and_number_conversions
branch
from
ec8d8d1 to
947f588
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
e95504c to
f15d69d
Compare
lorisleiva
force-pushed
the
04-24-add_fixed-point_string_and_number_conversions
branch
from
947f588 to
9d7fc99
Compare
lorisleiva
changed the base branch from
04-24-add_fixed-point_string_and_number_conversions
to
graphite-base/1568
This PR adds `getBinaryFixedPointCodec`, `getDecimalFixedPointCodec`, and their encoder/decoder counterparts to `@solana/fixed-points`. Each factory takes a signedness, total bits, scale, and an optional `FixedPointCodecConfig` (`{ endian?: 'le' | 'be' }`, defaults to little-endian), and produces a `FixedSizeCodec` whose byte-size literal is preserved for widths that are multiples of 8 from 8 to 256 bits. Non-byte-aligned total bits throw a `SOLANA_ERROR__FIXED_POINTS__TOTAL_BITS_NOT_BYTE_ALIGNED` error.
The byte-level IO uses `DataView.setBigUint64`/`getBigUint64` for every 64-bit chunk, then greedily consumes the remaining 0-7 bytes with at most one `setUint32`/`setUint16` and a direct byte write. This matches `@solana/codecs-numbers` performance for common widths (u8/u16/u32/u64/u128) and stays efficient for non-standard widths like u24/u40/u72. The read path uses `toArrayBuffer` from `@solana/codecs-core` so it works in environments where `SharedArrayBuffer` is undefined (React Native, non-isolated browsers). In the future, the number codecs in `@solana/codecs-numbers` could delegate to these more generic fixed-point codecs under the hood.
lorisleiva
force-pushed
the
04-24-add_fixed-point_codecs
branch
from
f15d69d to
6d87c49
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // Full 64-bit chunks. LE lays chunks low-to-high; BE lays higher-order | ||
| // chunks at lower memory addresses. | ||
| for (let c = 0; c < fullChunks; c++) { | ||
| const chunk = (unsigned >> BigInt(c * 64)) & MASK_64; |
| let consumed = 0; | ||
|
|
||
| if (residual - consumed >= 4) { | ||
| const chunk = Number((residualChunk >> BigInt(consumed * 8)) & MASK_32); |
| consumed += 4; | ||
| } | ||
| if (residual - consumed >= 2) { | ||
| const chunk = Number((residualChunk >> BigInt(consumed * 8)) & MASK_16); |
| consumed += 2; | ||
| } | ||
| if (residual - consumed >= 1) { | ||
| const chunk = Number((residualChunk >> BigInt(consumed * 8)) & MASK_8); |
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
getBinaryFixedPointCodec,getDecimalFixedPointCodec, and their encoder/decoder counterparts to@solana/fixed-points. Each factory takes a signedness, total bits, scale, and an optionalFixedPointCodecConfig({ endian?: 'le' | 'be' }, defaults to little-endian), and produces aFixedSizeCodecwhose byte-size literal is preserved for widths that are multiples of 8 from 8 to 256 bits. Non-byte-aligned total bits throw aSOLANA_ERROR__FIXED_POINTS__TOTAL_BITS_NOT_BYTE_ALIGNEDerror.The byte-level IO uses
DataView.setBigUint64/getBigUint64for every 64-bit chunk, then greedily consumes the remaining 0-7 bytes with at most onesetUint32/setUint16and a direct byte write. This matches@solana/codecs-numbersperformance for common widths (u8/u16/u32/u64/u128) and stays efficient for non-standard widths like u24/u40/u72. The read path usestoArrayBufferfrom@solana/codecs-coreso it works in environments whereSharedArrayBufferis undefined (React Native, non-isolated browsers). In the future, the number codecs in@solana/codecs-numberscould delegate to these more generic fixed-point codecs under the hood.