Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strong-kids-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solana/react': patch
---

Return immediately when passing empty array of transactions to `useSignTransactions` and `useSignAndSendTransactions`
15 changes: 15 additions & 0 deletions packages/react/src/__tests__/useSignAndSendTransaction-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,21 @@ describe('useSignAndSendTransaction', () => {
});
});
describe('useSignAndSendTransactions', () => {
it('returns empty output without calling the wallet implementation when given no inputs', async () => {
expect.assertions(2);
const { result } = renderHook(() => useSignAndSendTransactions(mockUiWalletAccount, 'solana:danknet'));
// eslint-disable-next-line jest/no-conditional-in-test
if (result.__type === 'error' || !result.current) {
throw result.current;
} else {
const signAndSendTransactions = result.current;
const results = await signAndSendTransactions();
// eslint-disable-next-line jest/no-conditional-expect
expect(results).toEqual([]);
// eslint-disable-next-line jest/no-conditional-expect
expect(mockSignAndSendTransaction).not.toHaveBeenCalled();
}
});
it("passes through multiple inputs to the wallet's `signAndSendTransaction` implementation", async () => {
expect.assertions(3);
mockSignAndSendTransaction.mockResolvedValueOnce([{ signature: 'abc' }, { signature: 'def' }]);
Expand Down
15 changes: 15 additions & 0 deletions packages/react/src/__tests__/useSignTransaction-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,21 @@ describe('useSignTransaction', () => {
});
});
describe('useSignTransactions', () => {
it('returns empty output without calling the wallet implementation when given no inputs', async () => {
expect.assertions(2);
const { result } = renderHook(() => useSignTransactions(mockUiWalletAccount, 'solana:danknet'));
// eslint-disable-next-line jest/no-conditional-in-test
if (result.__type === 'error' || !result.current) {
throw result.current;
} else {
const signTransactions = result.current;
const results = await signTransactions();
// eslint-disable-next-line jest/no-conditional-expect
expect(results).toEqual([]);
// eslint-disable-next-line jest/no-conditional-expect
expect(mockSignTransaction).not.toHaveBeenCalled();
}
});
it("passes through multiple inputs to the wallet's `signTransaction` implementation", async () => {
expect.assertions(3);
mockSignTransaction.mockResolvedValueOnce([{ signature: 'abc' }, { signature: 'def' }]);
Expand Down
3 changes: 3 additions & 0 deletions packages/react/src/useSignAndSendTransaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ export function useSignAndSendTransactions<TWalletAccount extends UiWalletAccoun
const account = getWalletAccountForUiWalletAccount_DO_NOT_USE_OR_YOU_WILL_BE_FIRED(uiWalletAccount);
return useCallback(
async (...inputs) => {
if (inputs.length === 0) {
return [];
}
const inputsWithChainAndAccount = inputs.map(({ options, ...rest }) => {
const minContextSlot = options?.minContextSlot;
return {
Expand Down
3 changes: 3 additions & 0 deletions packages/react/src/useSignTransaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ export function useSignTransactions<TWalletAccount extends UiWalletAccount>(
const account = getWalletAccountForUiWalletAccount_DO_NOT_USE_OR_YOU_WILL_BE_FIRED(uiWalletAccount);
return useCallback(
async (...inputs) => {
if (inputs.length === 0) {
return [];
}
const inputsWithAccountAndChain = inputs.map(({ options, ...rest }) => {
const minContextSlot = options?.minContextSlot;
return {
Expand Down
Loading