From 8beb20775dec1ea22e732484f5fc1ab6438da22d Mon Sep 17 00:00:00 2001 From: Loris Leiva Date: Wed, 7 Jan 2026 13:07:16 +0000 Subject: [PATCH] Make `ws` a direct dependency --- .changeset/yummy-ghosts-push.md | 5 +++++ .../rpc-subscriptions-channel-websocket/package.json | 11 +++-------- packages/ws-impl/package.json | 11 +++-------- 3 files changed, 11 insertions(+), 16 deletions(-) create mode 100644 .changeset/yummy-ghosts-push.md diff --git a/.changeset/yummy-ghosts-push.md b/.changeset/yummy-ghosts-push.md new file mode 100644 index 000000000..251485d6c --- /dev/null +++ b/.changeset/yummy-ghosts-push.md @@ -0,0 +1,5 @@ +--- +'@solana/rpc-subscriptions-channel-websocket': patch +--- + +Node users no longer need to manually install `ws`. Browser builds remain unaffected as conditional exports ensure `ws` is never bundled for browser environments. diff --git a/packages/rpc-subscriptions-channel-websocket/package.json b/packages/rpc-subscriptions-channel-websocket/package.json index cac1082b6..879f027fe 100644 --- a/packages/rpc-subscriptions-channel-websocket/package.json +++ b/packages/rpc-subscriptions-channel-websocket/package.json @@ -76,7 +76,8 @@ "@solana/errors": "workspace:*", "@solana/functional": "workspace:*", "@solana/rpc-subscriptions-spec": "workspace:*", - "@solana/subscribable": "workspace:*" + "@solana/subscribable": "workspace:*", + "ws": "^8.18.0" }, "devDependencies": { "@solana/event-target-impl": "workspace:*", @@ -84,13 +85,7 @@ "jest-websocket-mock": "^2.5.0" }, "peerDependencies": { - "typescript": ">=5.9.3", - "ws": "^8.18.0" - }, - "peerDependenciesMeta": { - "ws": { - "optional": true - } + "typescript": ">=5.9.3" }, "engines": { "node": ">=20.18.0" diff --git a/packages/ws-impl/package.json b/packages/ws-impl/package.json index b0b070b63..de9ee6b8d 100644 --- a/packages/ws-impl/package.json +++ b/packages/ws-impl/package.json @@ -51,16 +51,11 @@ "supports bigint and not dead", "maintained node versions" ], - "devDependencies": { - "@types/ws": "^8.18.1" - }, - "peerDependencies": { + "dependencies": { "ws": "^8.18.0" }, - "peerDependenciesMeta": { - "ws": { - "optional": true - } + "devDependencies": { + "@types/ws": "^8.18.1" }, "engines": { "node": ">=20.18.0"